You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sbillinge it can not be fixed quickly. I think we can put it in the next release.
Though the implementation might be simple, one of the tests depends on the iterPars. This test will be skipped unless diffpy.srreal and diffpy.structure are installed. Now diffpy.srreal is not available for python==3.13. We might want to wait until diffpy.srreal is successfully updated, and then we can run all the tests that involve iterPars.
@sbillinge I believe the PR #183 have fixed this issue that equal type atoms should have same ADP by doing a global recursive search. We have incorporated some test to test the behavior and why we did not close this issue immediately is because I forgot to make the Close issue comment in the PR.
Activity
ycexiao commentedon Jul 29, 2025
@sbillinge it can not be fixed quickly. I think we can put it in the next release.
Though the implementation might be simple, one of the tests depends on the
iterPars. This test will be skipped unlessdiffpy.srrealanddiffpy.structureare installed. Nowdiffpy.srrealis not available forpython==3.13. We might want to wait untildiffpy.srrealis successfully updated, and then we can run all the tests that involveiterPars.stevenhua0320 commentedon May 21, 2026
@sbillinge I believe we can close this as we fixed via #183
sbillinge commentedon May 22, 2026
Can we confirm this and I will close
stevenhua0320 commentedon May 22, 2026
@sbillinge I believe the PR #183 have fixed this issue that equal type atoms should have same ADP by doing a global recursive search. We have incorporated some test to test the behavior and why we did not close this issue immediately is because I forgot to make the
Close issuecomment in the PR.sbillinge commentedon May 30, 2026
closed by #183