Repository navigation
refactor and style: Refactor unittest tests for in favor of pytest and update docstrings in fitbase - #222
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
===========================================
+ Coverage 71.63% 85.13% +13.50%
===========================================
Files 25 43 +18
Lines 3437 4751 +1314
===========================================
+ Hits 2462 4045 +1583
+ Misses 975 706 -269
🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge ready for review. After this PR is merged we can go ahead with the |
sbillinge
reviewed
Oct 13, 2026
sbillinge
left a comment
Contributor
There was a problem hiding this comment.
Haha, that is way to much to review, but I trust Claude on that.
Contributor
Author
|
@sbillinge haha yeah. I skimmed over each line to make sure things look reasonable. Caught some stylization things but overall looked good. |
Contributor
Author
|
Also since its a refactor it knows the behavior we want to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR standardizes
diffpy.srfit.fitbaseby:pytestgroup standardstest_simplerecipe.pyThe new architecture for testing the deprecated functions is moving them into
tests/deprecated/so when they are removed they are easy to find and are organized