Skip to content

chore: point README CI badge at matrix-and-codecov.yml - #224

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:ci-badge-fix
Oct 14, 2026
Merged

sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:ci-badge-fix

Conversation

@cadenmyers13

Copy link
Copy Markdown
Contributor

closes #212

The badge referenced matrix-and-codecov-on-merge-to-main.yml, which no longer exists. Also add the missing .rst extension to news/use-string-in-structure.

The badge referenced matrix-and-codecov-on-merge-to-main.yml, which no
longer exists. Also add the missing .rst extension to
news/use-string-in-structure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (a9eae82) to head (4096ab6).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #224       +/-   ##
===========================================
+ Coverage   71.63%   85.13%   +13.50%     
===========================================
  Files          25       43       +18     
  Lines        3437     4751     +1314     
===========================================
+ Hits         2462     4045     +1583     
+ Misses        975      706      -269     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge

Copy link
Copy Markdown
Contributor

That wrong filename indicates an out of date skpkg. Please could you quickly run package update on srfit and see if we are missing anything else and report back? It should be quick.

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge Looks like its fixed on skpkg main but isn't live because it hasnt been released

@sbillinge

Copy link
Copy Markdown
Contributor

@sbillinge Looks like its fixed on skpkg main but isn't live because it hasnt been released

please can you expand a bit? I am not sure what you are saying. Did you run package update and what did you get?

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge I ran package update and package create public and both gave me the broken version. I went to go fix it in scikit-package but it has already been fixed there. The fix just hasn't been released

@sbillinge

Copy link
Copy Markdown
Contributor

OK, gotcha. we will work on a new release for 3.15 work, so this will go out then. For now, I assume that there is not much else changed and waiting to go out and we can just update that file-name as you already did.

@sbillinge
sbillinge merged commit a6f53d3 into diffpy:main Oct 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: CI badge fix

2 participants