[cadenmyers13]

No description provided.

[cadenmyers13]

@sbillinge ready for review

[codecov]

Codecov Report

❌ Patch coverage is 51.64835% with 88 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.21%. Comparing base (507aa4e) to head (9a5d14f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
tests/deprecated/test_pdf_deprecations.py	59.33%	61 Missing ⚠️
tests/test_pdfcontribution.py	17.39%	19 Missing ⚠️
tests/test_pdfgenerator.py	11.11%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   84.95%   84.21%   -0.75%     
==========================================
  Files          44       46       +2     
  Lines        4886     5094     +208     
==========================================
+ Hits         4151     4290     +139     
- Misses        735      804      +69     

Files with missing lines	Coverage Δ
tests/test_characteristicfunctions.py	54.16% <ø> (-0.24%)	⬇️
tests/test_pdfgenerator.py	16.66% <11.11%> (ø)
tests/test_pdfcontribution.py	39.02% <17.39%> (ø)
tests/deprecated/test_pdf_deprecations.py	59.33% <59.33%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cadenmyers13]

@sbillinge fixed the merge conflict. ready for review

[cadenmyers13]

btw, codecov here fails because all the PDF tests are skipped because we removed srreal as a dependency

[sbillinge]

btw, codecov here fails because all the PDF tests are skipped because we removed srreal as a dependency

Is this the reason:

The Srreal code is still present because it is deprecated but not removed yet. The tests are still there but being skipped because srreal is not installed as a dependency. I wonder if a better approach is to just add srreal in our test script if it is possible and leave the tests running? Or does that cause problems?

[cadenmyers13]

@sbillinge Adding it to tests.txt doesn't work because its not released to python 3.14 yet. I think its okay for codecov to fail like this for now since we are going to be removing anything dependent on diffpy.srreal anyways