Skip to content

fix: rename RecipeOrganizer.get_constrained_parmeters to get_constrained_parameters - #239

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:fix-typo
Oct 28, 2026
Merged

sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:fix-typo

Conversation

@cadenmyers13

Copy link
Copy Markdown
Contributor

Correct the typo in the snake_case name added in 3.4.0, and point the getConstrainedPars forwarder and its deprecation test at the corrected name. This is a plain rename with no deprecation period; the misspelled name was only just released.

…ned_parameters

Correct the typo in the snake_case name added in 3.4.0, and point the
getConstrainedPars forwarder and its deprecation test at the corrected
name. This is a plain rename with no deprecation period; the misspelled
name was only just released.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review. This typo slipped through but i think its okay as this is mostly an internal function and people dont use it in refinements

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.21%. Comparing base (507aa4e) to head (256f506).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   84.95%   84.21%   -0.75%     
==========================================
  Files          44       46       +2     
  Lines        4886     5094     +208     
==========================================
+ Hits         4151     4290     +139     
- Misses        735      804      +69     
Files with missing lines Coverage Δ
...ts/deprecated/test_recipeorganizer_deprecations.py 100.00% <ø> (ø)
tests/test_recipeorganizer.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
sbillinge merged commit fd18f84 into diffpy:main Oct 28, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants