Repository navigation
feat: deprecate diffpy.srfit.sas and SASCF in favor of diffpy.cmisas - #240
Open
cadenmyers13 wants to merge 1 commit into
Open
cadenmyers13 wants to merge 1 commit into
cadenmyers13 wants to merge 1 commit into
Conversation
Importing diffpy.srfit.sas now warns and points to diffpy.cmisas, as diffpy.srfit.structure and diffpy.srfit.pdf already do. SASCF warns on construction and points to diffpy.cmisas.characteristicfunctions.SASCF. Closes diffpy#235 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 84.95% 84.28% -0.68%
==========================================
Files 44 47 +3
Lines 4886 5115 +229
==========================================
+ Hits 4151 4311 +160
- Misses 735 804 +69
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing diffpy.srfit.sas now warns and points to diffpy.cmisas, as diffpy.srfit.structure and diffpy.srfit.pdf already do. SASCF warns on construction and points to diffpy.cmisas.characteristicfunctions.SASCF.
Closes #235