Skip to content

chore: use external libdiffpy - #98

Open
SYMSCAE wants to merge 3 commits into
diffpy:mainfrom
SYMSCAE:external-libdiffpy
Open

SYMSCAE wants to merge 3 commits into
diffpy:mainfrom
SYMSCAE:external-libdiffpy

Conversation

@SYMSCAE

@SYMSCAE SYMSCAE commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

This PR reverts the change that vendors libdiffpy. CI is expected to fail until a new libdiffpy release is availble in conda.

@SYMSCAE
SYMSCAE marked this pull request as draft October 12, 2026 22:01
@SYMSCAE

SYMSCAE commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge PR ready for review. But I'll mark it as draft for now until we have a new libdiffpy release.

Comment thread README.rst Resolved
@sbillinge

Copy link
Copy Markdown
Contributor

@SYMSCAE this is still failing. It maybe just waiting for the upcoming release of libdiffpy? Please confirm and give an update on the progress there.

@SYMSCAE

SYMSCAE commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@SYMSCAE this is still failing. It maybe just waiting for the upcoming release of libdiffpy? Please confirm and give an update on the progress there.

The tests fail for different reasons. This PR test fails because we reverted back to use external libdiffpy and I've set this to expect 1.5.0+ (it will fail for 1.4.0 for another reason since function signature changed).

The other two tests fail because the commit hash and checksum mismatches (which could be caused by branch changes and we shouldn't bother further as we're not vendoring libdiffpy).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants