Repository navigation
ci: modify skpkg ci and update the release issue template - #58
Conversation
|
@sbillinge Ready for review. Is libdiffpy supported on Windows? Claude is telling me no. Maybe @SYMSCAE can answer this too. @SYMSCAE Can you review this PR too? |
|
btw, the check news item CI only runs on PRs to |
|
I made this issue. Maybe people have thought of this earlier and we dont want this, but i made it anyways scikit-package/scikit-package#739 |
| env.Replace(CXX=os.environ.get('CXX', os.path.join(prefix, 'bin', 'c++'))) | ||
| env.Prepend(CCFLAGS=['-isystem' + os.path.join(prefix, 'include')]) | ||
| env.Append(LIBPATH=os.path.join(prefix, 'lib')) | ||
| env.Append(LINKFLAGS='-Wl,-rpath,' + os.path.join(prefix, 'lib')) |
There was a problem hiding this comment.
@cadenmyers13 Windows is actually supported, and is using a separate compiler msvc, which its compile flags are not universal with this.
There was a problem hiding this comment.
@SYMSCAE I think this is going to involve more work than what should be done on scikit-package migration. I'm thinking I'll undo this changes. What do you think? Unless you can write CI for the matrix testing. This is out of my wheelhouse
There was a problem hiding this comment.
@SYMSCAE I think this is going to involve more work than what should be done on scikit-package migration. I'm thinking I'll undo this changes. What do you think? Unless you can write CI for the matrix testing. This is out of my wheelhouse
I've just checked and it is indeed more work than expected. We have to fix dllexport and such (which is present in v1.4.1 release source but not in main) as well as ci. I will open an issue and make a PR once this gets merged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@sbillinge ready for review. I simplified this a lot more by reusing some workflow. an issue has been opened for making a matrix test |
This PR update the CI for libdiffpy.
Here's a summary of all the CI in libdiffpy.
tests-on-pr.ymlruns tests on a PRcheck-news-item.ymlchecks that a news item is present in a PRrelease-github-on-tag.ymlruns the release workflow ongit push upstream <tag>build-and-publish-docs-on-dispatch.ymlbuilds and publishes docs on a successful releaseExtra care needs to be taken for matrix testing (an issue has been opened).
We also cant use
_release-docs.ymlbecause it runspip install -e . --no-depsbeforemake -C docs html, which fails for the same reason. It also checks out without git tags, and the docs read the library version from those tags.The "hardcoded" workflows follow the same steps as the reusable versions (miniconda from conda-forge, the
requirements/*.txtfiles, Codecov, thegh-pagesdeploy) and callscons/gcovr/makedirectly.tests-on-pr.ymlwas already written this way in #56.We still use the reusable workflows wherever they don't depend on Python:
_check-news-item,_check-tag-privilege,_check-pat-token-validityand_release-github.If C++ projects should use the shared workflows too, release-scripts would need inputs for the install and test commands (or a
c_librarymode). This might be easy to implement considering scikit-package asks if the package contains C++ code.