Skip to content

doc: skip Python package installation when building docs - #65

Merged
sbillinge merged 3 commits into
diffpy:skpkg-migrationfrom
SYMSCAE:doc
Oct 31, 2026
Merged

sbillinge merged 3 commits into
diffpy:skpkg-migrationfrom
SYMSCAE:doc

Conversation

@SYMSCAE

@SYMSCAE SYMSCAE commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

This PR skips the Python package installation when building libdiffpy documentation since libdiffpy is a pure C++ library.

@SYMSCAE

SYMSCAE commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge PR ready for review.

@sbillinge

Copy link
Copy Markdown
Contributor

In the future we may have trouble remembering what this means in the workflow. I wonder if we need a mroe descriptive name, or a comment above describing what happens when either true or false are selected for this variable.

@SYMSCAE SYMSCAE changed the title doc: don't install as python package when making docs doc: skip Python package installation when building docs Oct 31, 2026
@SYMSCAE

SYMSCAE commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge Please see if this is what we want. Also pre-commit is up.

@sbillinge
sbillinge merged commit dc3a403 into diffpy:skpkg-migration Oct 31, 2026
2 checks passed
@sbillinge

Copy link
Copy Markdown
Contributor

Perfect, thanks

@SYMSCAE
SYMSCAE deleted the doc branch October 31, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants