Skip to content

fix: Update brotli version to 1.2.1 for security improvements - #1297

Merged
gibahjoe merged 2 commits into
mainfrom
fix/brotli-security-update
Oct 29, 2026
Merged

gibahjoe merged 2 commits into
mainfrom
fix/brotli-security-update

Conversation

@gibahjoe

@gibahjoe gibahjoe commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Updates Brotli from 1.1.0 to 1.2.1 in the performance-test dependencies to address CVE-2026-111497.

Adds brotli>=1.2.1 to requirements.in and regenerates the lockfile.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Validated in an isolated Python 3.10 container:

No UI changes; browser testing is not applicable.

Added/updated tests?

  • Yes
  • No, and this is why: Dependency-only security update with no application behaviour changes. Verified dependency compatibility and Brotli functionality using the checks above.
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

Reinstall dependencies in existing performance-test environments. Rebuild and rescan any images containing this dependency set.

[optional] Are there any dependencies on other PRs or Work?

None.

Summary by CodeRabbit

  • Chores
    • Updated the performance-testing setup to use Brotli 1.2.1 and keep its requirement declarations aligned.
    • These changes are limited to the performance-testing environment. They do not add or alter any end-user-facing features or application behavior.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b718fef9-7ece-4cbd-a7e6-023780f11810

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 73399b74-22b8-4c0d-82a5-5a2c43f1c649
Commits

Reviewing files that changed from the base of the PR and between 1d47f6c and 83cfc59.

Files selected for processing: 2
  • performance-test/requirements.in
  • performance-test/requirements.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The performance-test requirements now specify Brotli 1.2.1 or later. The pinned requirements update Brotli to 1.2.1 and include requirements.in as a dependency source.

Changes

Performance-test dependencies

Layer / File(s) Summary
Brotli requirement and pin
performance-test/requirements.in, performance-test/requirements.txt
The input requirements add brotli>=1.2.1. The pinned requirements update Brotli to 1.2.1 and list requirements.in alongside geventhttpclient.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: cpcundill

Merge Risk: Minimal · previous review 83cfc

The dependency update is ready to merge with normal installation checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating Brotli to version 1.2.1 for security improvements.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version line,
Brotli’s pin is now in line.
Requirements list the source,
Both files follow the same course.
The rabbit hops away, all fine.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.34% 3120 / 4034
🔵 Statements 76.69% 3341 / 4356
🔵 Functions 72.27% 644 / 891
🔵 Branches 70.78% 1609 / 2273
File CoverageNo changed files found.
Generated in workflow #1678 for commit 76f11f2 by the Vitest Coverage Report Action

@gibahjoe
gibahjoe merged commit ad7c9e2 into main Oct 29, 2026
9 of 11 checks passed
@gibahjoe
gibahjoe deleted the fix/brotli-security-update branch October 29, 2026 12:59

This branch was previously deployed

1 inactive deployment
development — 76f11f28 Deployed Oct 29, 2026 by ernest-tpximpact via run-tests / test #3025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants