Skip to content

fix: show issue-table row when the issue is on a hidden field - #1298

Merged
Ben-Hodgkiss merged 1 commit into
mainfrom
fix/issue-table-hidden-field-column
Oct 30, 2026
Merged

Ben-Hodgkiss merged 1 commit into
mainfrom
fix/issue-table-hidden-field-column

Conversation

@Ben-Hodgkiss

@Ben-Hodgkiss Ben-Hodgkiss commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

The endpoint task issue table only displays columns from the dataset specification, with system fields such as 'organisation' removed. When an issue is on one of those hidden fields (e.g. Invalid Organisation on brownfield-land) no cell is flagged, rowHasError is false and the row is filtered out, leaving an empty table under a non-zero issue count.

Add any issue field that is not already displayed as an extra column in prepareTableParams so the row appears with the invalid value highlighted.

Claude-Session: https://claude.ai/code/session_01GJw4QHMnuoj3fHSE7JPrp1

Related Tickets & Documents

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Summary by CodeRabbit

  • Bug Fixes
    • Issues affecting fields omitted from the specification now appear in the table with their values and error messages.

The endpoint task issue table only displays columns from the dataset
specification, with system fields such as 'organisation' removed. When an
issue is on one of those hidden fields (e.g. Invalid Organisation on
brownfield-land) no cell is flagged, rowHasError is false and the row is
filtered out, leaving an empty table under a non-zero issue count.

Add any issue field that is not already displayed as an extra column in
prepareTableParams so the row appears with the invalid value highlighted.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GJw4QHMnuoj3fHSE7JPrp1
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2000dc32-b8d9-4ab7-aafa-37da607086f1
Commits

Reviewing files that changed from the base of the PR and between ad7c9e2 and 07b6df9.

Files selected for processing: 2
  • src/middleware/issueTable.middleware.js
  • test/unit/middleware/issueTable.middleware.test.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

prepareTableParams now adds an issue’s field to the table columns when neither that field nor its replacement field is displayed. A unit test checks an omitted organisation field and confirms that the original field list remains unchanged.

Changes

Issue table field handling

Layer / File(s) Summary
Add and test omitted issue fields
src/middleware/issueTable.middleware.js, test/unit/middleware/issueTable.middleware.test.js
The middleware adds an issue field to the columns when neither it nor its replacement field is displayed. The test checks that the row remains visible with its issue value and error, and that uniqueDatasetFields remains unchanged.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: gibahjoe

Merge Risk: Minimal · up to 07b6d

The change adds omitted issue fields to the table data so affected rows can display their invalid values and errors. No merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: showing issue-table rows when the issue concerns a hidden field.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the columns in the morning light,
An omitted field now joins the rows in sight.
The issue value and error stay in view,
The original field list remains unchanged too.
The rabbit hops along, its review complete.

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.35% 3123 / 4037
🔵 Statements 76.72% 3345 / 4360
🔵 Functions 72.27% 644 / 891
🔵 Branches 70.86% 1615 / 2279
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/middleware/issueTable.middleware.js 98.27% 89.58% 100% 98.11% 129
Generated in workflow #1679 for commit 07b6df9 by the Vitest Coverage Report Action

@Ben-Hodgkiss Ben-Hodgkiss changed the title Show issue-table row when the issue is on a hidden field fix: show issue-table row when the issue is on a hidden field Oct 30, 2026

@pooleycodes pooleycodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ben-Hodgkiss
Ben-Hodgkiss merged commit 1db89f4 into main Oct 30, 2026
7 checks passed
@Ben-Hodgkiss
Ben-Hodgkiss deleted the fix/issue-table-hidden-field-column branch October 30, 2026 12:09

This branch was previously deployed

1 inactive deployment
development — 07b6df93 Deployed Oct 30, 2026 by Ben-Hodgkiss via deploy-changes (development) / deploy #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid Organisation issue entry is not showning on Brownfield Land task list

3 participants