Repository navigation
fix: show issue-table row when the issue is on a hidden field - #1298
Conversation
The endpoint task issue table only displays columns from the dataset specification, with system fields such as 'organisation' removed. When an issue is on one of those hidden fields (e.g. Invalid Organisation on brownfield-land) no cell is flagged, rowHasError is false and the row is filtered out, leaving an empty table under a non-zero issue count. Add any issue field that is not already displayed as an extra column in prepareTableParams so the row appears with the invalid value highlighted. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GJw4QHMnuoj3fHSE7JPrp1
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add and test omitted issue fields src/middleware/issueTable.middleware.js, test/unit/middleware/issueTable.middleware.test.js |
The middleware adds an issue field to the columns when neither it nor its replacement field is displayed. The test checks that the row remains visible with its issue value and error, and that uniqueDatasetFields remains unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: gibahjoe
Merge Risk: 
Minimal · up to 07b6d
-
The change adds omitted issue fields to the table data so affected rows can display their invalid values and errors. No merge-blocking risk is established.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the columns in the morning light,
An omitted field now joins the rows in sight.
The issue value and error stay in view,
The original field list remains unchanged too.
The rabbit hops along, its review complete.
Comment @coderabbitai help to get the list of available commands.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
What type of PR is this? (check all applicable)
Description
The endpoint task issue table only displays columns from the dataset specification, with system fields such as 'organisation' removed. When an issue is on one of those hidden fields (e.g. Invalid Organisation on brownfield-land) no cell is flagged, rowHasError is false and the row is filtered out, leaving an empty table under a non-zero issue count.
Add any issue field that is not already displayed as an extra column in prepareTableParams so the row appears with the invalid value highlighted.
Claude-Session: https://claude.ai/code/session_01GJw4QHMnuoj3fHSE7JPrp1
Related Tickets & Documents
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
Summary by CodeRabbit