Repository navigation
Fix PR build: run Build job on ubuntu-24.04 with Python 3.9 - #4021
Merged
Merged
Conversation
The cross-request script pins github3.py 1.3.0, which imports Callable from collections and fails on Python 3.10+, so the earlier move to 3.12 broke the Build job. setup-python has no 3.9 build for Ubuntu 26.04 (the current ubuntu-latest), so pin this job to ubuntu-24.04 until mobile-deploy supports newer Python. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
OrangeAndGreen
approved these changes
Nov 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4021 +/- ##
============================================
- Coverage 33.78% 33.77% -0.02%
+ Complexity 5113 5110 -3
============================================
Files 782 782
Lines 51871 51871
Branches 6535 6535
============================================
- Hits 17526 17520 -6
- Misses 32045 32052 +7
+ Partials 2300 2299 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Summary
Follow-up to #4020, which didn't fix the build.
GitHub's
ubuntu-latestnow resolves to Ubuntu 26.04.actions/setup-pythonhas no Python 3.9 build for that image, so the Build job failed at "Install python". #4020 moved the job to Python 3.12, but then the cross-request step failed instead. The script it downloads fromdimagi/mobile-deploypinsgithub3.py==1.3.0, which can't be imported on Python 3.10 or newer:This PR is the short-term fix. The Build job now runs on
ubuntu-24.04and goes back to Python 3.9, which setup-python still provides for 22.04 and 24.04. A comment onruns-onexplains why it's pinned.The proper fix is dimagi/mobile-deploy#21, which moves those scripts to github3.py 4.x. Once that merges, this job can go back to
ubuntu-latestwith a current Python.Documentation
None. CI-only change.
Safety Assurance
Safety story
This only changes CI config and doesn't touch the app. Before Ubuntu 26.04 became
ubuntu-latest, this job ran on 24.04 with Python 3.9 (that was whatubuntu-latestmeant), so this goes back to a known-good setup. The workflow run on this PR checks it.Automated test coverage
This PR's own workflow run covers it.
Labels and Review
🤖 Generated with Claude Code