Skip to content

fix(skills): preserve strict gateway params - #465

Closed
jmagar wants to merge 1 commit into
mainfrom
fix/skills-owner-param
Closed

jmagar wants to merge 1 commit into
mainfrom
fix/skills-owner-param

Conversation

@jmagar

@jmagar jmagar commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • stop HTTP and MCP transports from injecting runtime owner/origin fields into gateway actions that do not consume them
  • centralize the mutation-only runtime owner policy in labby-gateway
  • add API/MCP regression coverage so strict gateway.skills.list params remain untouched while mutation provenance is preserved

Root cause

The transport layers enriched every gateway action with internal runtime provenance. gateway.skills.list intentionally uses deny_unknown_fields and only accepts upstream, so the injected owner field made the Skills page fail with invalid gateway params: unknown field owner.

Verification

  • cargo test -p labby-gateway runtime_owner_metadata_is_limited_to_actions_that_consume_it
  • cargo test -p labby gateway_owner_injection
  • cargo test -p labby gateway_origin_tests
  • cargo test -p labby --features skills gateway_owner_injection
  • cargo clippy -p labby-gateway --all-targets --features skills -- -D warnings
  • cargo clippy -p labby --all-targets --features skills -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

@jmagar
jmagar force-pushed the fix/skills-owner-param branch 3 times, most recently from cdc1664 to 21b124a Compare August 20, 2026 06:08
@jmagar
jmagar force-pushed the fix/skills-owner-param branch from 21b124a to 21ee137 Compare August 20, 2026 06:35
@jmagar

jmagar commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #467, which incorporated this strict gateway-parameter fix and has already merged to main.

@jmagar jmagar closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant