Repository navigation
Conversation
jmagar
force-pushed
the
fix/skills-owner-param
branch
3 times, most recently
from
August 20, 2026 06:08
cdc1664 to
21b124a
Compare
jmagar
force-pushed
the
fix/skills-owner-param
branch
from
August 20, 2026 06:35
21b124a to
21ee137
Compare
Collaborator
Author
|
Superseded by #467, which incorporated this strict gateway-parameter fix and has already merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
owner/originfields into gateway actions that do not consume themlabby-gatewaygateway.skills.listparams remain untouched while mutation provenance is preservedRoot cause
The transport layers enriched every gateway action with internal runtime provenance.
gateway.skills.listintentionally usesdeny_unknown_fieldsand only acceptsupstream, so the injectedownerfield made the Skills page fail withinvalid gateway params: unknown field owner.Verification
cargo test -p labby-gateway runtime_owner_metadata_is_limited_to_actions_that_consume_itcargo test -p labby gateway_owner_injectioncargo test -p labby gateway_origin_testscargo test -p labby --features skills gateway_owner_injectioncargo clippy -p labby-gateway --all-targets --features skills -- -D warningscargo clippy -p labby --all-targets --features skills -- -D warningscargo fmt --all -- --checkgit diff --check