Skip to content

fix(ci): verify daemon and explicit canary uploads #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmagar merged 1 commit into from
Oct 1, 2026
Merged

fix(ci): verify daemon and explicit canary uploads #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/hosted-kache-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ jobs:
kache daemon stop
kache sync --push --manifest-path "$CANARY_MANIFEST" 2>&1 \
| tee "$RUNNER_TEMP/kache-seed-sync.log"
grep -Eq 'Uploaded:[[:space:]]+1/1' "$RUNNER_TEMP/kache-seed-sync.log"
# The daemon may already have uploaded the entry while compiling.
# The fresh verify runner must still download it and record a cache hit.
grep -Eq 'Uploaded:[[:space:]]+1/1|Listing remote keys\.\.\.[[:space:]]+1 keys' \
"$RUNNER_TEMP/kache-seed-sync.log"
- name: Record seed evidence
run: |
kache report --format json \
Expand Down
4 changes: 4 additions & 0 deletions tests/test_validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,10 @@ def test_canary_upload_is_scoped_to_its_build_root(self) -> None:
self.assertIn('kache sync --push --manifest-path "$CANARY_MANIFEST"', upload["run"])
self.assertLess(upload["run"].index("kache daemon stop"), upload["run"].index("kache sync"))
self.assertIn("Uploaded:", upload["run"])
self.assertIn("Listing remote keys", upload["run"])
verify = workflow["jobs"]["verify"]["steps"]
self.assertTrue(any("Downloaded:" in step.get("run", "") for step in verify))
self.assertTrue(any(".misses == 0" in step.get("run", "") for step in verify))

def test_platform_release_cache_stays_credentialless(self) -> None:
workflow = yaml.load(
Expand Down
Loading