Repository navigation
[LOW] Pin workflow actions to immutable commits - #68
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
LOW urgency. The scheduled database-update workflow grants
contents: writeandpull-requests: write. Mutable action tags let a later upstream tag move change the code executed with that token. Full commit SHAs keep the reviewed workflow dependency immutable.The same pins are applied to the read-only CI jobs for consistency. This is workflow supply-chain hardening; I did not identify an exploitable runtime issue in
mini_mime.Verification
bundle exec rake test— 34 runs, 74 assertions, 0 failures/errorsbundle exec rubocop— 13 files, no offensesuses:reference is a full 40-character SHAmini_mime-2.0.0.gem; expected eight packaged filesgit diff --checkLimitations
This does not pin RubyGems updated by the monthly database workflow. Those updates are committed to a pull request and remain subject to repository review.
Breaking changes
None. Runtime and packaged gem contents are unchanged.