Repository navigation
Switch from npm to pnpm - #201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the development tooling of
nextfrom npm to pnpm (from #198, was #136):pnpm-lock.yaml, converted frompackage-lock.jsonwithpnpm import, so it has the same resolved versions, and"packageManager": "pnpm@12.9.0".pnpm-workspace.yamlallows the build script ofsqlite3. It also sets esbuild tofalse, because pnpm 12 fails the install for unapproved build scripts, and esbuild's script only checks its binary, which comes from an optional dependency anyway. pnpm 12 calls this settingallowBuilds, notonlyBuiltDependencies.tediousis^20.3.0, locked to 20.3.6: pnpm only installs packages older than a day by default (minimumReleaseAge), and 20.3.7 was younger than that.peggy5.1.0 is a devDependency, sobuild:parsersno longer needsnpx.pnpm/action-setup@v6andpnpm install --frozen-lockfile.contributing.md, the docker-compose comments and the test session's hint use pnpm. The user-facing install docs and the standalone examples keepnpm install.pnpm packandnpm packproduce the same files.lib/andtypings/are identical, andpackage.jsononly differs in the changed scripts and devDependencies, plus pnpm movingscriptsto the end. Locally the full suite passes (5916 tests, lint, typings), and so do the parser check, TypeScript 5.1 and the docs build.