Repository navigation
Apply first() of relation mapping modifiers and onBuild() hooks per parent (#127) - #338
Merged
Merged
Conversation
lehni
force-pushed
the
fix/rc-first-per-parent
branch
2 times, most recently
from
October 12, 2026 19:35
b7df3f3 to
4174299
Compare
lehni
force-pushed
the
fix/rc-first-per-parent
branch
from
October 12, 2026 21:14
4174299 to
67e9328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
first()in a relation mapping'smodify, or in anonBuild()hook of a graph modifier, limits the related models of each parent to one again under thelimitPerParentdefault.LimitPerParentOperationreadsfirst()as a limit of 1 when the query is built, andfirst()doesn't unwrap the result of a query that is limited per parent.Why
WhereInEagerOperationturnedfirst()intolimit(1)right after the graph modifiers ran. The relation mapping'smodifyandonBuild()hooks run later, while the query is built, so theirfirst()stayed a plainfirst(): only one parent of the whole batch got a related model and the others gotnull. 3.9.0 withlimitPerParent: trueapplied it per parent.Tests
should apply first() of a relation mapping modify per parentshould apply first() of an onBuild() hook per parentBoth fail without the change.
Part of #53.