Repository navigation
janus_collector: server selected collection job id - #4898
Open
tgeoghegan wants to merge 1 commit into
Conversation
jcjones
reviewed
Oct 13, 2026
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector
branch
2 times, most recently
from
October 17, 2026 13:01
20814da to
6fb964a
Compare
tgeoghegan
added
the
allow-changed-migrations
tgeoghegan
changed the base branch from
main
to
timg/leader-selected-collection-job-idempotency-key-server
October 17, 2026 13:02
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector
branch
from
October 17, 2026 13:02
6fb964a to
6633229
Compare
tgeoghegan
added this pull request to stack #4914
October 17, 2026 21:40
divergentdave
approved these changes
Oct 19, 2026
Comment on lines
+1044
to
+1048
| let encoded_idempotency_key = URL_SAFE_NO_PAD.encode( | ||
| LeaderSelectedQueryConfig::test_default() | ||
| .get_encoded() | ||
| .unwrap(), | ||
| ); |
Collaborator
There was a problem hiding this comment.
This is now incorrectly including a length prefix in the expected value.
Suggested change
| let encoded_idempotency_key = URL_SAFE_NO_PAD.encode( | |
| LeaderSelectedQueryConfig::test_default() | |
| .get_encoded() | |
| .unwrap(), | |
| ); | |
| let encoded_idempotency_key = URL_SAFE_NO_PAD.encode( | |
| LeaderSelectedQueryConfig::test_default().as_ref(), | |
| ); |
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector
branch
from
October 19, 2026 17:17
6633229 to
da50f55
Compare
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector
branch
3 times, most recently
from
October 19, 2026 18:10
83e2857 to
f3951dd
Compare
Adds support to `janus_collector` and the `collect` bin in `janus_tools` for server selected collection job IDs and leader-selected batch mode idempotency keys, per DAP changes in [1]. [1]: ietf-wg-ppm/draft-ietf-ppm-dap#797
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector
branch
from
October 19, 2026 18:36
f3951dd to
ee16826
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to
janus_collectorand thecollectbin injanus_toolsfor server selected collection job IDs and leader-selected batch mode idempotency keys, per DAP changes in 1.