Repository navigation
interop/integration: server selected job IDs - #4899
Open
Conversation
tgeoghegan
added a commit
that referenced
this pull request
Oct 13, 2026
These tests will be re-enabled in #4899.
tgeoghegan
added a commit
that referenced
this pull request
Oct 13, 2026
These tests will be re-enabled in #4899.
tgeoghegan
added a commit
that referenced
this pull request
Oct 13, 2026
These tests will be re-enabled in #4899.
divergentdave
approved these changes
Oct 14, 2026
| Query::new_leader_selected( | ||
| janus_messages::batch_mode::LeaderSelectedQueryConfig::default(), | ||
| ), | ||
| Query::new_leader_selected(random()), |
Collaborator
There was a problem hiding this comment.
We can consider this for a future enhancement, but we may want to have the collection_start API take the idempotency token from the test driver, for maximum flexibility.
tgeoghegan
added a commit
that referenced
this pull request
Oct 16, 2026
These tests will be re-enabled in #4899.
tgeoghegan
added a commit
that referenced
this pull request
Oct 16, 2026
These tests will be re-enabled in #4899.
tgeoghegan
added a commit
that referenced
this pull request
Oct 16, 2026
These tests will be re-enabled in #4899.
tgeoghegan
changed the base branch from
main
to
timg/leader-selected-collection-job-idempotency-key-collector
October 17, 2026 21:41
tgeoghegan
added this pull request to stack #4914
October 17, 2026 21:41
tgeoghegan
added a commit
that referenced
this pull request
Oct 19, 2026
These tests will be re-enabled in #4899.
tgeoghegan
added a commit
that referenced
this pull request
Oct 19, 2026
These tests will be re-enabled in #4899.
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector-integration-interop
branch
from
October 19, 2026 17:36
4e26016 to
1daed49
Compare
Adds support to `janus_collector` and the `collect` bin in `janus_tools` for server selected collection job IDs and leader-selected batch mode idempotency keys, per DAP changes in [1]. [1]: ietf-wg-ppm/draft-ietf-ppm-dap#797
Adds support to interop binaries and integration tests for server selected collection job IDs and leader-selected batch mode idempotency keys. Re-enables previously neutered integration tests in CI. See <ietf-wg-ppm/draft-ietf-ppm-dap#797>
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-collector-integration-interop
branch
from
October 19, 2026 18:11
1daed49 to
72aea19
Compare
jcjones
approved these changes
Oct 19, 2026
| Op::LeaderGarbageCollector, | ||
| Op::CollectorStart { | ||
| collection_job_id, | ||
| query: Query::TimeInterval( |
Contributor
There was a problem hiding this comment.
nit: The asynchronous version of this test uses query.clone() here
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to interop binaries and integration tests for server selected collection job IDs and leader-selected batch mode idempotency keys.
Re-enables previously neutered integration tests in CI.
See ietf-wg-ppm/draft-ietf-ppm-dap#797