Repository navigation
Tests for deleted/expired aggregate share creation - #4916
Draft
tgeoghegan wants to merge 2 commits into
Draft
tgeoghegan wants to merge 2 commits into
tgeoghegan wants to merge 2 commits into
Conversation
Adds test cases for trying to re-create collection jobs that have been either deleted explicitly by a DELETE or implicitly by their constituent data expiring. Along the way, we do some pretty significant refactoring of `CollectionJobTest` so that various test setup routines become methods on that type.
Adds test cases for trying to re-create aggregate shares that have been either deleted explicitly by a DELETE or implicitly by their constituent data expiring. Along the way, we do some pretty significant refactoring of test setup routines.
tgeoghegan
added this pull request to stack #4914
October 19, 2026 18:32
Contributor
Author
|
These tests may have to change a fair bit when we migrate the helper aggregate share endpoint to draft-ietf-ppm-dap-20. But at least all the setup work will still be useful, and we'll see something noisily break when we change the endpoint's semantics. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases for trying to re-create aggregate shares that have been either deleted explicitly by a DELETE or implicitly by their constituent data expiring. Along the way, we do some pretty significant refactoring of test setup routines.