Bump actions/upload-artifact from 4 to 5#9
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Author
|
Superseded by #32. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/upload-artifact-5
branch
December 15, 2025 18:32
dkam
added a commit
that referenced
this pull request
Jun 21, 2026
…orrectness Address review items #5–#9 (silent wrong data in dashboards and MCP): - #5 nil project_id percentiles: histogram_percentile bound `project_id = ?` directly, so a nil ("all projects") caller matched zero rows and reported 0ms. MCP get_transaction_stats / get_endpoint_summary call percentiles_for_endpoint with no project_id. Bind project_id only when present (same conditional treatment as environment). - #16/#5 global_percentile: replace non-sargable COALESCE(?, project_id) with the same conditional bind. - #9 name-filtered header percentiles: the endpoints index header used Transaction.percentiles (no name filter) while the table below honored ?name=. Add a name_query LIKE filter threaded through percentiles -> global_percentile (transaction_histograms already carries transaction_name). - #7 dropped endpoint-stats keys: stats_by_endpoint_with_impact and endpoints_by_n_plus_one no longer returned the p50/p95/p99_duration, avg_queries, max_queries, n_plus_one_count, total_count, n_plus_one_pct keys that the dashboard views and MCP formatters read (rendered blank/0). Restore them — query stats from the grouped scan, histogram-backed percentiles computed only for the returned top-N via a shared endpoint_percentiles helper. - #6 MCP get_endpoint_timeseries crash: format_endpoint_timeseries read symbol keys (b[:count], b[:bucket_start], b[:avg_duration]) but time_series_for_endpoint returns string-keyed buckets with an integer index and p50/p95/p99 (no avg/bucket_start). Rewrite the formatter to the real shape; derive each bucket's wall-clock start from the window origin. - #8 MCP search_slow_transactions: http_method was parsed but never passed through, and endpoint matched transaction_name by exact equality despite the schema advertising a substring match. Add http_method to Transaction.slow and switch the name filter to LIKE %…%. Also fixes a latent collision found while verifying #8: `scope :slow` (no-arg, duration > 1000) was defined after `include TransactionAnalytics`, silently overriding the slow(time_range:, …) method MCP search_slow_transactions calls — so that tool would have raised ArgumentError at runtime. The scope had no app callers; remove it and point its one test at the analytics method. Verified end-to-end against seeded data (percentiles non-zero for nil project, name filter scopes correctly, all consumer keys present, substring + method filtering, timeseries shape). Suite green apart from the 4 pre-existing main-branch failures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 5.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
330a01cMerge pull request #734 from actions/danwkennedy/prepare-5.0.003f2824Updategithub.dep.yml905a1ecPreparev5.0.02d9f9cdMerge pull request #725 from patrikpolyak/patch-19687587Merge branch 'main' into patch-12848b2cMerge pull request #727 from danwkennedy/patch-19b51177Spell out the first use of GHEScd231caUpdate GHES guidance to include reference to Node 20 versionde65e23Merge pull request #712 from actions/nebuk89-patch-18747d8cUpdate README.mdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)