Repository navigation
feat(view)!: run worktree-overview status providers off the main loop - #364
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Async results can reorder unpredictably, and the primary delayed-callback behavior lacks coverage.
4 open findings
What changed in this PR
Moves worktree status collection to an asynchronous callback-based provider API.
Changes:
- Adds concurrent provider collection, timeout handling, and stale-result guards.
- Updates functional tests and provider documentation.
| File | Description |
|---|---|
worktree_overview_view.lua |
Implements asynchronous status collection. |
worktree_overview_hooks_spec.lua |
Adapts provider tests to callbacks. |
doc/diffview.txt |
Documents the new provider contract. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+72
| local provider = function(e, done) | ||
| calls[#calls + 1] = e.path | ||
| if e.path == linked then | ||
| return "working" | ||
| done("working") |
dlyongemallo
force-pushed
the
worktree_move_status_providers_off_main_loop
branch
from
October 14, 2026 05:33
dbe546b to
b86a32b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #334.