Clean up SDK packs and manifests on uninstall - #351
Merged
Conversation
Remove SDK-owned reference packs and safely prune workload manifests while preserving files shared by other SDKs or workloads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
Resolve overlap with the merged directory-scoped uninstall and prune fixes while retaining the stronger pack-cleanup coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
Distinguish known-empty SDK manifest ownership from legacy unknown records, and preserve SDK-provided packs referenced by workload installation metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
Use Serde string conversions for the v10 SDK directory wrapper instead of a custom serializer implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
Use Serde type-wide proxy registration for direct and collection SemVersion members while retaining the explicit nullable wrapper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk-manifestsfeature bands contributed by each SDK archiveWorkload-owned packs such as iOS, Android, Mono, and AOT cross-compilation packs are not removed.
Testing
dotnet test test/UnitTests/UnitTests.csproj --nologo(196 passed)dotnet test test/IntegrationTests/IntegrationTests.csproj --nologo(18 passed, 1 skipped)