Skip to content

Upgrade pod2 for sparse array literals - #237

Open
robknight wants to merge 1 commit into
mainfrom
sdk-pod2-sparse-arrays
Open

robknight wants to merge 1 commit into
mainfrom
sdk-pod2-sparse-arrays

Conversation

@robknight

Copy link
Copy Markdown
Collaborator

This upgrades POD2 to the latest version, adding support for sparse arrays, as well as some API changes which produce errors rather than panics.

@robknight
robknight requested a review from ed255 October 2, 2026 13:33

@ed255 ed255 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

does not support sparse-array literals"
);
return write!(f, "{}", Value::from(value.raw()));
write!(f, "[")?;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change desired?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so - it includes the literal array in the Podlang output, which has always been possible for non-sparse arrays, and is now possible for sparse arrays too. Previously sparse arrays defaulted to using the commitment rather than the array literal.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants