Repository navigation
Conversation
Generated-with: gpt-6.1-sol (Codex)
|
Welcome to DokuZen! Thank you for submitting a pull request. We will review your contribution shortly. |
|
Zweitreview (Cloud-Bot): Diff plausibel, Wirksamkeit noch offen
Empfehlung: Auf „Ready for review“ setzen, damit CI läuft. Schlägt es weiter fehl, zusätzlich Generated by Claude Code |
|
Independent review by gpt-6.1-sol (separate instance), exact head 63996a4. Full single-file diff and complete collection test module read. The session fixture retains QApplication; the dependent factory retains each dialog and, on teardown, closes it, schedules deletion and drains DeferredDelete while the application is alive. All original assertion ASTs are identical; only tests/test_pdf_collection.py changes, with no product/dependency/timeout/skip/version change. Windows Python 3.12, Qt/shiboken 6.11.1, offscreen: 28 collection/publication tests passed and the process exited successfully; Ruff on the changed file and git diff --check passed. A direct fixture lifecycle probe confirms shiboken.isValid(dialog) becomes false while QApplication.instance() remains the same live application. Exact-head six native source-smoke cells (Windows/Linux/macOS x Python3.11/3.12) are successful; the workflow runs the collection tests explicitly. No blocking finding in this test-lifecycle change. The old remote Linux crash was not independently reproduced on this Windows/Qt version; no full-product/physical-GUI acceptance claim. Explicit Draft/merge-disabled hold preserved; no ready or merge action. |
Current source-platform CI38174254168 fails four of six cells after successful collection assertions; Linux reports shared QObject deletion then exit139 after 28 passed. Two collection GUI tests create QApplication in a local variable and only close dialogs. Keep one session-scoped QApplication and own each dialog through a fixture that closes it, schedules deletion and drains deferred deletion before releasing the application. Product code and all PDF/export assertions remain unchanged. Local Windows Python3.12 Qt/shiboken6.11.1: unchanged base28passed with clean exit; changed28passed with clean exit; diff check passed. This local baseline does not reproduce the remote crash; exact-head six-platform CI must validate the proposed lifecycle correction. No skips, timeout extensions, dependency changes or releases. Author model: gpt-6.1-sol (Codex). Independent review pending; Draft; merges disabled.