cli-plugins/hooks: fix max message enforcement#7058
Open
mohithshuka wants to merge 1 commit into
Open
Conversation
The --filter flag description for 'docker volume prune' only mentioned 'label=<label>' but not 'label!=<label>', even though the label! filter is supported and handled correctly by the underlying PruneFilters function. This commit: - Updates the --filter flag description to include label!=<label> - Adds a unit test for the label! filter to match the existing label filter test Fixes docker#6918 Signed-off-by: mohithshuka <YOUR_ID+mohithshuka@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support and coverage for negated label filters (label!=...) in volume prune, including updated CLI help text and golden output.
Changes:
- Added a new prune test-case validating
--filter label!=...is parsed into the expected API filters. - Updated the
--filterflag help text to documentlabel!=<label>. - Added a golden file for the new test scenario’s expected output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/command/volume/testdata/volume-prune-success.label-not-filter.golden | Adds expected output for the new label!=... prune scenario. |
| cli/command/volume/prune_test.go | Adds a test case asserting correct parsing/mapping of label!=foobar into filters. |
| cli/command/volume/prune.go | Updates CLI help text to mention label!=<label> as a supported filter form. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --filter flag description for 'docker volume prune' only mentioned 'label=' but not 'label!=', even though the label! filter is supported and handled correctly by the underlying PruneFilters function.
This commit:
Fixes #6918
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)