Repository navigation
Conversation
Signed-off-by: Ankit Kumar <ankitkumar19473@gmail.com>
|
✅ DCO Check Passed Thanks @ankit2235, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Hi, friendly ping in case this got lost, happy to change anything if needed. |
Signed-off-by: Ankit Kumar <ankitkumar19473@gmail.com> # Conflicts: # docling/backend/latex/utils/text.py
AI triage (advisory)Checked commit This pull request updates Topic labels added: CI safety: no concern found. A maintainer must still approve CI. 1 related pull request(s) in the same code
The |
There was a problem hiding this comment.
AI first review (advisory): no blocker found
This review covers the full diff at 765e1a36c4. It read the code and did not run it.
I found no defect that blocks the merge. The new regex in _extract_verbatim_content handles the three cases in the PR. The minted language is skipped only for minted, and the group patterns use disjoint alternatives, so they do not backtrack badly. The regression test checks the exact code text, so it fails on the old pattern.
A maintainer makes the merge decision. This review never approves the pull request.
_extract_verbatim_contentonly skipped an optional[...]after\begin{env}, using a non-greedy\[.*?\]. Two cases leaked markup into the code item:mintedtakes a mandatory language argument, which became the first line of the code:\begin{minted}{python}gave{python}\nx = 1.lstlistingoption value containing], such ascaption={A [nested] cap}, ended the option match early and leftcap}]in the code.The pattern now skips an optional argument whose
{...}values may contain brackets, and, formintedonly, the{language}argument after it.verbatim, plainlstlisting, multi-line options, and code that itself starts with[or{behave as before.The new parametrized test covers
mintedwith and without options andlstlistingwith a bracketed caption, with an indented code line so the first-line indentation from #4502 stays covered. It fails onmainand passes with this change; the other LaTeX tests pass unchanged.Using minted's language (or lstlisting's
language=) as the code item's language is left for a follow-up.Issue resolved by this Pull Request:
Resolves #4542
Checklist: