Repository navigation
fix(pptx): move hidden-shape content to invisible layer - #4743
Closed
bunnysayzz wants to merge 2 commits into
Closed
bunnysayzz wants to merge 2 commits into
bunnysayzz wants to merge 2 commits into
Conversation
Shapes hidden via PowerPoint's Selection Pane (p:cNvPr hidden="1") had their text emitted on the body layer. Like hidden slides (docling-project#4647), their content is now kept on the invisible layer instead. Signed-off-by: bunnysayzz <stfuazzo@gmail.com>
Contributor
|
❌ DCO Check Failed Hi @bunnysayzz, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for bunnysayzz <stfuazzo@gmail.com>
I, bunnysayzz <stfuazzo@gmail.com>, hereby add my Signed-off-by to this commit: 0c8bc419a1d27bfb6f09102a5316449c8e907aa0"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #4732
Shapes hidden via PowerPoint Selection Pane (
p:cNvPrhidden="1") had their text emitted on the body layer of shown slides. Like hidden slides (#4647), the content is now kept on the invisible layer instead.Checklist:
test_pptx_hidden_shape_goes_to_invisible_layer), green; fails without the fix