Skip to content

fix(pptx): move hidden-shape content to invisible layer - #4743

Closed
bunnysayzz wants to merge 2 commits into
docling-project:mainfrom
bunnysayzz:fix/hidden-shape-invisible-4732
Closed

bunnysayzz wants to merge 2 commits into
docling-project:mainfrom
bunnysayzz:fix/hidden-shape-invisible-4732

Conversation

@bunnysayzz

Copy link
Copy Markdown
Contributor

Issue resolved by this Pull Request:
Resolves #4732

Shapes hidden via PowerPoint Selection Pane (p:cNvPr hidden="1") had their text emitted on the body layer of shown slides. Like hidden slides (#4647), the content is now kept on the invisible layer instead.

Checklist:

  • Tests added (test_pptx_hidden_shape_goes_to_invisible_layer), green; fails without the fix
  • Conventional Commits title, DCO sign-off on the commit

Shapes hidden via PowerPoint's Selection Pane (p:cNvPr hidden="1") had their text emitted on the body layer. Like hidden slides (docling-project#4647), their content is now kept on the invisible layer instead.

Signed-off-by: bunnysayzz <stfuazzo@gmail.com>
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

❌ DCO Check Failed

Hi @bunnysayzz, your pull request has failed the Developer Certificate of Origin (DCO) check.

This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format.


🛠 Quick Fix: Add a remediation commit

Run this command:

git commit --allow-empty -s -m "DCO Remediation Commit for bunnysayzz <stfuazzo@gmail.com>

I, bunnysayzz <stfuazzo@gmail.com>, hereby add my Signed-off-by to this commit: 0c8bc419a1d27bfb6f09102a5316449c8e907aa0"
git push

🔧 Advanced: Sign off each commit directly

For the latest commit:

git commit --amend --signoff
git push --force-with-lease

For multiple commits:

git rebase --signoff origin/main
git push --force-with-lease

More info: DCO check report

@mergify

mergify Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@bunnysayzz bunnysayzz closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PPTX: text of a hidden shape on a shown slide is emitted as body content

1 participant