Repository navigation
fix(odf): move hidden ODP slides to the invisible content layer - #4767
Merged
PeterStaar-IBM merged 1 commit intoOct 12, 2026
Merged
Conversation
Signed-off-by: Ankit Kumar <ankitkumar19473@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @ankit2235, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
PeterStaar-IBM
self-requested a review
October 12, 2026 03:27
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slide hidden in an OpenDocument presentation (
presentation:visibility="hidden"on itsstyle:drawing-page-properties) was converted like a normal slide, so its text went into the body and the default exports.The content of a hidden slide now goes to
ContentLayer.INVISIBLE, the same as hidden ODS sheets in this backend and hidden PowerPoint slides and shapes (#4647, #4733). It stays available to callers who request that layer, and the default exports leave it out. Visible slides are unchanged.With the Google Slides export attached to #4765, the Markdown export now contains only slide 1; the hidden slide 2 is in the invisible layer.
The new test builds a presentation with one visible and one hidden slide and checks the default Markdown export and the invisible layer. It fails on
mainand passes with this change; the other OpenDocument tests pass unchanged.Issue resolved by this Pull Request:
Resolves #4765
Checklist: