Repository navigation
feat(ASR): add transformers and MLX presets for the ASR pipelines - #4771
Conversation
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
|
✅ DCO Check Passed Thanks @PeterStaar-IBM, all your commits are properly signed off. 🎉 |
Merge Protections🟢 All 2 merge protections satisfied — ready to merge. Show 2 satisfied protections🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWhen test data is updated, we require two reviewers
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
AI triage (advisory)Checked commit The PR adds Transformers and MLX ASR presets for Granite, Nemotron, Parakeet CTC and Whisper, with a new CI safety: needs maintainer care before you approve CI.
4 related pull request(s) in the same code
Reference data changes
Assessment: unclear. The Markdown reference changes may follow from the The |
There was a problem hiding this comment.
AI first review (advisory): blocker found
This review covers the full diff at 76768ffefe. It read the code and did not run it.
The PR changes how the existing MLX Whisper model uses artifacts_path. This may break current Apple Silicon users who set artifacts_path for other models. Check whether this offline-only MLX behavior is intended and whether it needs a fallback or a release note.
A maintainer makes the merge decision. This review never approves the pull request.
|
@PeterStaar-IBM Thanks for adding these presets! I'm extremely familiar with Parakeet, Granite Speech, and the Transformers implementation of Whisper, and I've benchmarked all three, so feel free to delegate future tasks on them to me if you want. The only exception is MLX, which I can't help with. |
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
|
@PeterStaar-IBM thanks for explaining how you plan to implement this. I've done some extensive benchmarking on all of the models you're planning on adding and I can share them with you if you'd like. They include word error rate testing at various chunk sizes as well as "stitching" strategies. To summarize with respect to the models you want to add, here are my recommendations, followed by the results behind them: Recommendations
Results Setup: 15 long English recordings (7
Stitching
Other settings
I haven't tested the Whisper presets. Happy to share the scripts and per-recording results, or go into more depth on any of these. |
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
I like this evaluation, would it be possible (once merged) that we work together and:
|
|
Any way I can convince you to at least NOT include the nemotron models since they don't fill any "niche" that I can tell? ;-) And possibly my other recommended exclusions? But either way, yes, it'd be a fun project. Would it be within docling or I was perhaps looking at |
resolves: #4684
Summary
Checklist:
Review evidence: