Repository navigation
fix(pptx): keep a hyperlink attached to a whole shape - #4787
Conversation
A link stored as a:hlinkClick under the shape's p:cNvPr was dropped. The shape's text items now carry it unless they already have a link of their own. Click actions that are not links, such as a jump to another slide, are ignored. Signed-off-by: Praveen Mittal <pkmittal28@gmail.com>
|
✅ DCO Check Passed Thanks @mittalpk, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
AI triage (advisory)Checked commit The PR fixes shape-level hyperlinks in the PPTX backend. When a whole shape carries an `a:hlinkClick` action, its text items now receive the link unless they already have a run-level one. Topic labels added: CI safety: no concern found. A maintainer must still approve CI. 1 related pull request(s) in the same code
The |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
A hyperlink attached to a whole shape (
a:hlinkClickunderp:cNvPr, python-pptxshape.click_action.hyperlink.address) was dropped: the shape's text items hadhyperlink=None. They now carry the shape's link unless they already have one. A relative address becomes aPathand a URL anAnyUrl, as in the DOCX backend. Click actions that are not links, such as a jump to another slide, are ignored.This is independent of #4443, which handles run-level links (#4442). The two compose: a run's own link takes precedence, and the shape's link only fills items without one. Both touch
mspowerpoint_backend.py, so I'm happy to rebase on whichever lands first.Issue resolved by this Pull Request:
Resolves #4782
Checklist: