Skip to content

feat: support Gemma 4 E2B - #4839

Closed
chibchombiano26 wants to merge 1 commit into
docling-project:mainfrom
chibchombiano26:codex/beac-8357-chart-model
Closed

chibchombiano26 wants to merge 1 commit into
docling-project:mainfrom
chibchombiano26:codex/beac-8357-chart-model

Conversation

@chibchombiano26

@chibchombiano26 chibchombiano26 commented Oct 14, 2026 •

Copy link
Copy Markdown

...

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

❌ DCO Check Failed

Hi @chibchombiano26, your pull request has failed the Developer Certificate of Origin (DCO) check.

This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format.


🛠 Quick Fix: Add a remediation commit

Run this command:

git commit --allow-empty -s -m "DCO Remediation Commit for chibchombiano26 <2654397+chibchombiano26@users.noreply.github.com>

I, chibchombiano26 <2654397+chibchombiano26@users.noreply.github.com>, hereby add my Signed-off-by to this commit: c7c00c11225306b0a5df78eb9de091dbc3779fdc"
git push

🔧 Advanced: Sign off each commit directly

For the latest commit:

git commit --amend --signoff
git push --force-with-lease

For multiple commits:

git rebase --signoff origin/main
git push --force-with-lease

More info: DCO check report

@chibchombiano26
chibchombiano26 force-pushed the codex/beac-8357-chart-model branch from bdf0715 to c26854c Compare October 14, 2026 23:33
@mergify

mergify Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@chibchombiano26
chibchombiano26 marked this pull request as ready for review October 15, 2026 00:15
@github-actions github-actions Bot added ai:ci-safe AI triage found no CI-safety concern (advisory) enhancement New feature or request vlm-pipeline labels Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

AI triage (advisory)

Checked commit c7c00c1122. The analysis read the diff only. It did not run code from this pull request.

Warning

The AI analysis did not finish. Only the deterministic checks are shown.

CI safety: not assessed.

The ai:* labels are advisory. They do not approve CI and they do not add tests:full. A new push runs this check again.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI first review (advisory): blocker found

This review covers the full diff at 8fe112e33b. It read the code and did not run it.

The PR adds a chart verification VLM and per-model prompt overrides. The main risk is that _is_verified_chart — the sole function that decides whether extraction runs or is silently suppressed — has no regression test. The human reviewer must confirm that the new verification and prompt-override paths are covered by at least one test before merging.

A maintainer makes the merge decision. This review never approves the pull request.

SUPPORTED_CHART_TYPES = ["bar_chart", "pie_chart", "line_chart"]


def _is_verified_chart(response: str) -> bool:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocker: No regression test for the verification gate or prompt-override path

_is_verified_chart is the only function that decides whether chart extraction runs after verification. A bug in its regex strip or JSON parse returns False, silently suppressing extraction for every chart in the document without any error or log at ERROR level (only return False). The prompt_overrides path in __call__ (line 266) is also untested.

Neither _is_verified_chart nor any code that exercises verification_engine or prompt_overrides appears in tests/test_chart_extraction_tabledata.py or any other test file. AGENTS.md requires a focused test for behavior changes.

A minimal test should call _is_verified_chart with at least: a plain JSON true response, a fenced ```json response, a false response, and an unparseable response. A second test should confirm that prompt_overrides replaces the default prompt in batch_inputs.

@github-actions github-actions Bot added ai:review-changes AI first review suggests changes ai:ci-safe AI triage found no CI-safety concern (advisory) and removed ai:ci-safe AI triage found no CI-safety concern (advisory) ai:review-changes AI first review suggests changes labels Oct 15, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI first review (advisory): blocker found

This review covers the changes since 8fe112e33b at 67f191d370. It read the code and did not run it.

The new changes only add a chart description request (chart2summary) and a Markdown export to the API example, plus matching docs. They did not change the library code, and I found no new defect. The main risk is still that the library change in granite_vision.py has no test. This covers the _is_verified_chart gate that decides whether extraction runs, and the prompt_overrides path.

Earlier findings

  • open (blocker): No regression test for the verification gate or prompt-override path

A maintainer makes the merge decision. This review never approves the pull request.

@github-actions github-actions Bot added ai:review-changes AI first review suggests changes ai:ci-safe AI triage found no CI-safety concern (advisory) ai:ci-needs-care AI triage: check CI-safety findings before you approve CI and removed ai:ci-safe AI triage found no CI-safety concern (advisory) ai:review-changes AI first review suggests changes ai:ci-needs-care AI triage: check CI-safety findings before you approve CI labels Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

@chibchombiano26
chibchombiano26 force-pushed the codex/beac-8357-chart-model branch from 0664873 to c7c00c1 Compare October 15, 2026 05:47
@chibchombiano26 chibchombiano26 changed the title feat: configure chart verification and extraction vision models chore: withdrawn accidental pull request Oct 15, 2026
@github-actions github-actions Bot removed the ai:ci-safe AI triage found no CI-safety concern (advisory) label Oct 15, 2026
@chibchombiano26
chibchombiano26 deleted the codex/beac-8357-chart-model branch October 15, 2026 05:50
@chibchombiano26 chibchombiano26 changed the title chore: withdrawn accidental pull request feat: support Gemma 4 E2B Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request vlm-pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant