Repository navigation
perf(docx): memoize python-docx style lookups #4862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dolfim-ibm
merged 1 commit into
docling-project:main
from
wenqiw777:perf/docx-style-cache
Oct 19, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # SPDX-FileCopyrightText: The Docling Contributors | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| """Tests for Word style resolution. | ||
|
|
||
| Kept separate from ``test_backend_msword.py`` so that file stays under the | ||
| repository's per-file line limit. | ||
| """ | ||
|
|
||
| from docling_core.types.doc import DoclingDocument | ||
| from docx import Document | ||
|
|
||
| from docling.backend.msword_backend import MsWordDocumentBackend | ||
| from docling.datamodel.base_models import InputFormat | ||
| from docling.datamodel.document import InputDocument | ||
|
|
||
|
|
||
| def _convert_docx(document, docx_path) -> DoclingDocument: | ||
| document.save(str(docx_path)) | ||
| in_doc = InputDocument( | ||
| path_or_stream=docx_path, | ||
| format=InputFormat.DOCX, | ||
| backend=MsWordDocumentBackend, | ||
| filename=docx_path.name, | ||
| ) | ||
| return MsWordDocumentBackend(in_doc=in_doc, path_or_stream=docx_path).convert() | ||
|
|
||
|
|
||
| def test_style_lookups_do_not_leak_between_documents(tmp_path): | ||
| """Memoized style lookups must be scoped to the document they came from. | ||
|
|
||
| Both paragraphs resolve to the default paragraph style through the same | ||
| ``get_style(None, PARAGRAPH)`` lookup, but only the first document makes | ||
| that style bold. Converting them one after the other in one process must | ||
| report the bold of each document's own style. | ||
| """ | ||
| bold_doc = Document() | ||
| bold_doc.styles["Normal"].font.bold = True | ||
| bold_doc.add_paragraph("bold by style") | ||
| plain_doc = Document() | ||
| plain_doc.add_paragraph("plain") | ||
|
|
||
| bold_texts = _convert_docx(bold_doc, tmp_path / "bold.docx").texts | ||
| plain_texts = _convert_docx(plain_doc, tmp_path / "plain.docx").texts | ||
|
|
||
| assert [t.text for t in bold_texts] == ["bold by style"] | ||
| assert bold_texts[0].formatting is not None | ||
| assert bold_texts[0].formatting.bold is True | ||
| assert [t.text for t in plain_texts] == ["plain"] | ||
| assert plain_texts[0].formatting is not None | ||
| assert plain_texts[0].formatting.bold is False |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.