Repository navigation
fix(docx): normalize style type list to numbering to avoid load failure - #4868
Closed
taran-dev4u wants to merge 1 commit into
Closed
taran-dev4u wants to merge 1 commit into
taran-dev4u wants to merge 1 commit into
Conversation
Signed-off-by: Taran Mamidala <mamidalataran6333@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @taran-dev4u, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
taran-dev4u
marked this pull request as ready for review
October 16, 2026 22:25
Contributor
AI triage (advisory)Checked commit Normalize the DOCX style type Topic labels added: CI safety: no concern found. A maintainer must still approve CI. Possible duplicates
1 related pull request(s) in the same code
The |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4830
Some third-party generators declare styles with
w:type="list"inword/styles.xmlinstead ofw:type="numbering". Becausepython-docxmaps itsWD_STYLE_TYPE.LISTenum to XML value"numbering", encounteringlistraisesValueError: WD_STYLE_TYPE has no XML mapping for 'list'when resolving default styles or accessing unstyled paragraphs.This normalizes
w:type="list"tow:type="numbering"on loaded style elements inMsWordDocumentBackendbefore default style resolution, allowing python-docx to parse list styles asWD_STYLE_TYPE.LIST. Added unit testtest_docx_styles_xml_with_type_list_convertsintests/test_backend_msword.py.Checklist:
Review evidence:
ValueError: WD_STYLE_TYPE has no XML mapping for 'list'.pytest tests/test_backend_msword.py -k test_docx_styles_xml_with_type_list_converts(1 passed).tests/test_backend_msword.py(86 passed, 1 skipped).ruff check,ruff format --check, andtach check(all clean).