Repository navigation
Conversation
|
✅ DCO Check Passed Thanks @wfatih, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
AI triage (advisory)Checked commit This PR fixes CI safety: no concern found. A maintainer must still approve CI. 3 related pull request(s) in the same code
The |
There was a problem hiding this comment.
AI first review (advisory): no blocker found
This review covers the full diff at 0663f6edc9. It read the code and did not run it.
I found no defect. Both new flushes call _flush_text_data with the same parent that the neighbouring code uses for the next item. The two new tests assert the parent, the item order and the Markdown output, so they detect the original bug.
A maintainer makes the merge decision. This review never approves the pull request.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Paragraph text is only added at a blank line, a section header or a literal block. A list or a delimited table that follows the text directly left it pending, so it was added after the table, or inside the list group after the list items. Flush the pending text when a list or a delimited table starts. Signed-off-by: wfatih <ckrfth.s@gmail.com>
0663f6e to
ec62044
Compare
There was a problem hiding this comment.
AI first review (advisory): no blocker found
This review covers the full diff at ec62044264. It read the code and did not run it.
I found no defect. Both new _flush_text_data calls use the same parent that the next item uses, so the pending paragraph is no longer added after the list or table. The text is flushed before the block-title paragraph, so source order stays correct.
A maintainer makes the merge decision. This review never approves the pull request.
AsciiDocBackendcollects paragraph lines intext_dataand only adds them to the document at a blank line, a section header (#4428) or a literal block. When a list or a delimited table follows the text directly, the text stays pending and is added later, under whatever parent is current then:On
mainthe first input giveslist[a, b, paragraph "Intro:"]and the Markdown- a\n- b\nIntro:, so the paragraph sits inside the list after its items. The second gives the table first andBeforeafter it.This flushes the pending text when a list starts (before the bold block title paragraph, which keeps the source order) and when a
|===table opens, in the same way the section header branch already does. Nothing changes when a blank line separates the text from the list or table, because the text is already flushed there.Two new tests cover the list and the table case. Both fail on
mainand pass with this change.tests/test_backend_asciidoc.pypasses (44 passed) and no groundtruth changes.Checklist:
Review evidence:
Intro:\n* a\n* bexports as- a\n- b\nIntro:(the paragraph is a child of the list group).Before\n|===\n|a|b\n|===exports the table beforeBefore.Intro:\n\n- a\n- b, with the paragraph in the body before the list;Beforecomes before the table.pytest tests/test_backend_asciidoc.py: 44 passed. The new tests fail onmain(2 failed, 42 passed).tests/data/asciidoc/groundtruth/*) is unchanged.ruff checkandruff format --checkpass on the changed files.