Repository navigation
fix(odf): extract generated table of contents and index containers - #4882
Closed
taran-dev4u wants to merge 1 commit into
Closed
taran-dev4u wants to merge 1 commit into
taran-dev4u wants to merge 1 commit into
Conversation
Signed-off-by: Taran Mamidala <mamidalataran6333@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @taran-dev4u, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
Author
|
Closing in favor of #4750 by @ryanmeowy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ODT table-of-content containers (
text:table-of-contentand related index elements) were matching the unhandled element branch in_add_odf_child(), dropping the index title and entry paragraphs from the converted document.This change visits
text:index-bodychildren for table-of-content and other index containers, routing entries toContentLayer.BODYin source order (orContentLayer.INVISIBLEwhentext:display="none"is set).Issue resolved by this Pull Request:
Resolves #4749
Checklist:
Review evidence:
ContentLayer.BODY.tests/test_backend_opendocument.pycovering table-of-contents extraction, hidden TOCs, and illustration/table index containers. All 64 tests intest_backend_opendocument.pypass.ruff checkandruff format --checkpass on changed files.