Repository navigation
fix: preserve multiline DeepSeek and Unlimited OCR blocks - #4909
PierreMesure wants to merge 1 commit into
Conversation
Collect text and captions through the next annotation, preserving paragraphs while skipping markup already owned by a table. Fixes docling-project#4905. Signed-off-by: Pierre Mesure <pierre@mesu.re>
|
✅ DCO Check Passed Thanks @PierreMesure, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
AI triage (advisory)Checked commit The PR changes Topic labels added: CI safety: no concern found. A maintainer must still approve CI. The |
|
The AI code review did not produce a verdict for head 989aef0. The review job stopped with This is a bot execution failure, not a clean review. The four focused parser fixes were tested together again after the #4908 review fix: 129 passed, 1 skipped. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
DeepSeek and Unlimited OCR dropped every text or caption line after the first nonempty line. The shared collector now keeps content through the next annotation, including paragraph breaks. It skips lines already owned by a table, so table markup cannot become caption text.
Resolves #4905.
Checklist:
Review evidence:
CI=true .venv/bin/python -m pytest -q tests/test_ocr_multiline_blocks.py tests/test_unlimited_ocr_markdown.py tests/test_deepseekocr_vlm.py: 10 passed, 1 skipped on Python 3.12. The skipped test requires an external Ollama server.UV_NO_SYNC=1 make validate: all applicable hooks passed.