Repository navigation
Conversation
|
✅ DCO Check Passed Thanks @geoHeil, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
GPT-6.1 Sol review at final Docling head The production follow-up fixes both hosted findings. Auto-inline checks the native module and falls back to Transformers when the installed release lacks the port. Explicit MLX gives a clear error before downloading weights. Shipped dependencies use a normal version range; all six built wheel/sdist artifacts contain no direct dependency URLs. The signed Git pin is confined to development sources. Independent production tests: 117 passed, one existing skip. Final broader local tests: 128 passed, one existing skip. Independent final tests: 126 passed, two skipped, one deselected. The nested review runtime could not run one unchanged native-import test; the root run includes it. Final-head hosted CI: 46 checks passed, seven configured skips, no pending or failed checks. Codecov patch coverage is 100%, with 28 covered lines, no missed lines, and no partial lines. The real bf16 conversion was repeated after the selection fix. It checks table cells, document ownership, provenance, JSON, Markdown, and HTML. Native source All three public HF models were uploaded, downloaded, and reloaded locally. Report and reproduction commands. Float32 output is exact on the three checked pages. Reduced precision changes coordinates, some text, and classes. This local evidence does not run in CI. All hosted review threads are resolved. The PR stays draft, open, and unmerged until the upstream MLX port is released and the development pin can be replaced. |
AI triage (advisory)Checked commit This pull request adds native MLX engine support for the Nemotron 3.5 Parse model preset. It also adds a check for required native model modules during engine selection. CI safety: no concern found. A maintainer must still approve CI. The |
There was a problem hiding this comment.
AI first review (advisory): no blocker found
This review covers the full diff at ac187acdfc. It read the code and did not run it.
The MLX preset depends on a personal fork of mlx-vlm that is pinned by commit. The version gate cannot detect the missing port. Decide whether the fork pin may merge to the base branch. If it may, decide how auto-inline avoids choosing MLX on an mlx-vlm that lacks the port.
A maintainer makes the merge decision. This review never approves the pull request.
There was a problem hiding this comment.
AI first review (advisory): no blocker found
This review covers the changes since ac187acdfc at 3403bd736a. It read the code and did not run it.
The two earlier blockers are fixed: the version gate now checks the native module via engine_module_available, and the shipped extra keeps a version range (mlx-vlm>=0.7.9,<1.0.0), not a git URL. The [tool.uv.sources] git pin for the personal fork is still present and the PR description explicitly asks maintainers not to merge until upstream accepts the port. There are no code defects in the new logic.
Earlier findings
- fixed (question): Version gate does not detect an mlx-vlm without the Nemotron port
- answered (question): Fork source pin in a shipped extra, with allow-direct-references
A maintainer makes the merge decision. This review never approves the pull request.
|
yes this is meant to wait a bit and then decide; it looks like upstream is receptive - they addressed my PR/reviewed it today. givve it a bit of time |
|
Blaizzy/mlx-vlm#2562 is merged upstream now - once the next release is out we can continue here. so newer than (>= 0.7.10) should be workign then |
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
…upport Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
b93c1c4 to
708edd7
Compare
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
| model module is installed with `mlx-vlm` 0.7.11 or later. Otherwise, | ||
| auto-inline falls back to Transformers. MLX uses a | ||
| pinned `geoHeil/Nemotron-3.5-Parse-MLX-bf16` checkpoint and does not require | ||
| remote model code. On CUDA it selects Transformers, which runs code from its | ||
| model repository at a pinned revision. That engine requires |
There was a problem hiding this comment.
upstream is already merged, we only wait for a release
Enable the native MLX engine for
nemotron_parse_v3_5. Auto-inline selects MLX on Apple Silicon only when the installed package contains the native model module and meets the preset's engine requirement. Otherwise it selects Transformers, including on CUDA. Explicit MLX selection reports a missing module before it downloads weights.Closes #4932.
Native MLX requires
mlx-vlm0.7.11 or later and the native model module. The preset setsmin_engine_version="0.7.11". The native port is merged upstream in mlx-vlm #2562.pyproject.tomlanduv.lockmatch main.The MLX preset pins the published bf16 checkpoint. The 8-bit and 4-bit checkpoints remain available. It uses the existing Nemotron output mapper and needs no Hugging Face remote code. Explicit engine options override the preset's full-history repetition penalty settings.
Validation after rebase onto main
90234a71:make validate, hooks on all changed files, and commit hooks passed. No reference data changed.uv build --all-packages --no-sources. All six artifacts contain no direct dependency URLs.edadefc2. All 27 reported checks passed, including documentation, package tests, and Codecov patch coverage. Six workflow-configured checks were skipped.Earlier local fidelity report and reproduction commands: float32 matched the full Transformers output on the three checked pages. Reduced precision changed coordinates and some text/classes. These are limited fidelity samples, not accuracy scores. The port uses greedy decoding without MTP. Those full-model runs were not repeated for this dependency/documentation update.