fix(agents): stop triage on bot-sent events and recover a review verdict the agent did not file - #38
Merged
Merged
Conversation
…ict the agent did not file issue-triage: the agents caller also listens to pull_request_review and pull_request_review_comment, so the review agent's own inline comments reached claude-code-action as a Bot actor, which refuses it and fails the run. Every reviewed pull request carried a red triage check with nothing to triage. The bots step now stops on sender type Bot before the picker, keeping the Dependency Dashboard exception. pr-review: when the agent finishes without writing review-body.md, its final message is still the result entry of the execution file. The verdict step now recovers it, labels the recovery, warns, and passes; a pass that did the work no longer fails for a missed file write. A run with no execution file still fails as before. Fixes #36 Fixes #37 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two shared-workflow bugs that made
triage / triageandreview / reviewred on every agent-reviewed pull request today (kodni.me#227, dev-standards#26, nis-suite#80, infrasensing-senslogging#180).issue-triage.yml: the
botsstep now readsgithub.event.sender.typeand stops onBotbefore the runner picker. The agents caller listens topull_request_reviewandpull_request_review_comment, so the review agent's own inline comments were reaching claude-code-action as a Bot actor, which refuses it ("Workflow initiated by non-human actor: claude") and fails the run. The Dependency Dashboard exception is kept. Fixes #37.pr-review.yml: when the agent finishes without writing
review-body.md, the verdict step recovers its final message from the execution file'sresultentry, posts it with a visible "recovered" line, emits a warning, and passes. A run with no execution file still fails as before. Fixes #36.Validated with actionlint and a YAML parse. Behaviour change is limited to those two steps; no inputs added or removed, so
@v1callers are unaffected.🤖 Generated with Claude Code