ci(ci): mint the App token with client-id instead of the deprecated app-id - #146
Merged
Merged
Conversation
…pp-id The last workflow in the org still reading GH_APP_ID. The repo-level GH_APP_CLIENT_ID secret is set (this repo is public, so the org-level copy does not reach it); GH_APP_ID can go once this is on the default branch. Refs: D-0007 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Knowledge layer
Spec currency is reported in the job summary and never fails a build, the same severity the local pre-commit hook uses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-install-script.ymlwas the last workflow in the org still passingapp-id: ${{ secrets.GH_APP_ID }}toactions/create-github-app-token. Upstream deprecatedapp-idforclient-id, and every other repo moved toGH_APP_CLIENT_IDduring the fleet migration. The step comment also called this repo private, which it is not; corrected while there.Already done outside the PR: the repo-level secret
GH_APP_CLIENT_IDis set (public repos do not see the org-level secrets), so this change works the moment it lands.Operator action after merge:
gh secret delete GH_APP_ID -R dodi-smart/dirahq-cli.Verified: actionlint reports only the known
create-github-app-tokeninput-schema notes that the shared repo's self-test also ignores. The workflow runs on a schedule and onworkflow_dispatch; it was not dispatched from this branch because a real run opens a pull request in another repo.🤖 Generated with Claude Code