Repository navigation
fix: gateway stream idle timeout honors KIN_STREAM_IDLE_TIMEOUT (#485) - #506
Merged
Merged
Conversation
dofastted
marked this pull request as ready for review
October 17, 2026 09:51
Unify stream idle timeout resolution through resolveStreamIdleTimeoutMs() so handle-protocol no longer hardcodes 180_000 as fallback and skips env. Document cascade in PANEL_API and panel UI tip; add regression tests. Co-authored-by: ted <kuhlmangarry24@gmail.com>
cursor
Bot
force-pushed
the
cursor/stream-idle-timeout-env-485-5dd6
branch
from
October 17, 2026 09:52
dd196d7 to
554569a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #485: the gateway
/v1stream path usedNumber(cfg.limits.stream_idle_timeout_ms) || 180_000as the fallback tostreamIdleTimeoutMs(), which skippedKIN_STREAM_IDLE_TIMEOUTwhenevercfg.limitswas missing or non-finite.resolveStreamIdleTimeoutMs(routing, cfg)with cascade: panelfailover.stream_idle_timeout_ms→cfg.limits.stream_idle_timeout_ms→KIN_STREAM_IDLE_TIMEOUT→ 180_000 ms (unchanged default).handle-protocol.mjsthrough that helper (same pathvm-runtime.mjs/ kernel already use viastreamIdleTimeoutMs(routing)).docs/PANEL_API.mdand panel 「流空闲超时」tip.test/unit/routing-file.test.mjs.Out of scope (per product decision)
Test plan
node --test test/unit/routing-file.test.mjsnpm run format:check(Biome + web Prettier)npm run test:unit— 5 pre-existing failures onmain(database,egress,legacy-import,oauth-binary,session-oauth-seam); unrelated to this changeNote
Low Risk
Config-resolution bugfix on the gateway stream path only; default 180s unchanged and behavior is covered by unit tests.
Reviewed by Cursor Bugbot for commit 554569a. Configure here.