[Driver] Implement DriverManager - #72
Open
SwareJonge wants to merge 2 commits into
Open
Conversation
Report for MarioClub_us (da86f76 - 6434874)📈 Matched code: 46.61% (+0.11%, +3492 bytes) ✅ 17 new matches
📈 2 improvements in unmatched items
|
joakim-d
reviewed
Aug 11, 2026
joakim-d
left a comment
joakim-d
left a comment
Contributor
There was a problem hiding this comment.
Not 100% sure but all these members in the class looks weird no?
Why not using an array instead?
Comment on lines
+83
to
+126
| u8 _34; | ||
| u8 _35; | ||
| u8 _36; | ||
| u8 _37; | ||
| u8 _38; | ||
| u8 _39; | ||
| u8 _3a; | ||
| u8 _3b; | ||
| u8 _3c; | ||
| u8 _3d; | ||
| u8 _3e; | ||
| u8 _3f; | ||
| u8 _40; | ||
| u8 _41; | ||
| u8 _42; | ||
| u8 _43; | ||
| u8 _44; | ||
| u8 _45; | ||
| u8 _46; | ||
| u8 _47; | ||
| u8 _48; | ||
| u8 _49; | ||
| u8 _4a; | ||
| u8 _4b; | ||
| u8 _4c; | ||
| u8 _4d; | ||
| u8 _4e; | ||
| u8 _4f; | ||
| u8 _50; | ||
| u8 _51; | ||
| u8 _52; | ||
| u8 _53; | ||
| u8 _54; | ||
| u8 _55; | ||
| u8 _56; | ||
| u8 _57; | ||
| u8 _58; | ||
| u8 _59; | ||
| u8 _5a; | ||
| u8 _5b; | ||
| u8 _5c; | ||
| u8 _5d; | ||
| u8 _5e; | ||
| u8 _5f; |
Contributor
There was a problem hiding this comment.
Suggested change
| u8 _34; | |
| u8 _35; | |
| u8 _36; | |
| u8 _37; | |
| u8 _38; | |
| u8 _39; | |
| u8 _3a; | |
| u8 _3b; | |
| u8 _3c; | |
| u8 _3d; | |
| u8 _3e; | |
| u8 _3f; | |
| u8 _40; | |
| u8 _41; | |
| u8 _42; | |
| u8 _43; | |
| u8 _44; | |
| u8 _45; | |
| u8 _46; | |
| u8 _47; | |
| u8 _48; | |
| u8 _49; | |
| u8 _4a; | |
| u8 _4b; | |
| u8 _4c; | |
| u8 _4d; | |
| u8 _4e; | |
| u8 _4f; | |
| u8 _50; | |
| u8 _51; | |
| u8 _52; | |
| u8 _53; | |
| u8 _54; | |
| u8 _55; | |
| u8 _56; | |
| u8 _57; | |
| u8 _58; | |
| u8 _59; | |
| u8 _5a; | |
| u8 _5b; | |
| u8 _5c; | |
| u8 _5d; | |
| u8 _5e; | |
| u8 _5f; | |
| u8 _34[0x2c]; |
Why not using an array here?
Collaborator
Author
There was a problem hiding this comment.
Because I only use arrays when it gets accessed as an array(like in a loop)
Collaborator
Author
There was a problem hiding this comment.
They seem to get referenced by DriverModel::updateSetBlendWeight_GetBlendTime(StateEnum)
So I guess those are all related(_3c to _5a)
Collaborator
Author
There was a problem hiding this comment.
Yeah okay, I might indeed make it an array, however not the entire range you suggested
joakim-d
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low quality attempt, missing a lot of information about members at the moment