Skip to content

Add option for symbols order check during ninja build - #74

Open
joakim-d wants to merge 1 commit into
doldecomp:mainfrom
joakim-d:add_ninja_symbols_check
Open

Add option for symbols order check during ninja build#74
joakim-d wants to merge 1 commit into
doldecomp:mainfrom
joakim-d:add_ninja_symbols_check

Conversation

@joakim-d

@joakim-d joakim-d commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • Add an option configure.py file to automatically add symbols order check during ninja build
  • Modify tools/validate-symbol-order.py in order to set NM default variable as platform agnostic

@decomp-dev

decomp-dev Bot commented Aug 10, 2026

Copy link
Copy Markdown

Report for MarioClub_us (da86f76 - 3590a3c)

No changes

@SwareJonge

Copy link
Copy Markdown
Collaborator

looks good to me, however i'm not sure if the vfs/iso extraction part is needed, in the build instructions it says to put the iso/disc image into the orig folder and once running configure.py the image should be extracted(or when calling ninja). So the map should already be there.
I've never tested if it actually works like that tho, since i usually copypaste just the required files manually

@joakim-d

Copy link
Copy Markdown
Contributor Author

looks good to me, however i'm not sure if the vfs/iso extraction part is needed, in the build instructions it says to put the iso/disc image into the orig folder and once running configure.py the image should be extracted(or when calling ninja). So the map should already be there. I've never tested if it actually works like that tho, since i usually copypaste just the required files manually

That's weird because I only have the dol in this folder and no map file (I work on a Linux machine so I don't know if it could be related).
It looks like christian64 had the same issue and mentioned it in the discord conversation.
I'll investigate why.

@joakim-d
joakim-d force-pushed the add_ninja_symbols_check branch from 60ce0bd to 3590a3c Compare August 11, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants