Implement missing methods for GameAudio::Parameters - #75
Open
joakim-d wants to merge 1 commit into
Open
Conversation
joakim-d
commented
Aug 14, 2026
joakim-d
commented
Contributor
- Implement GameAudio::Parameters::setPlayerMode
- Implement GameAudio::Parameters::setRaceMode
- Set "Matching" for GameAudioParam.cpp
Report for MarioClub_us (da86f76 - 1f3b765)📈 Matched code: 46.55% (+0.05%, +1688 bytes) ✅ 7 new matches
|
joakim-d
commented
Aug 14, 2026
Comment on lines
+120
to
+121
| f32 _04; // 04 (referenceDistance) | ||
| f32 _08; // 08 (nearDistance) |
Contributor
Author
There was a problem hiding this comment.
FYI I did not rename those variables because another CPP file was being impacted and a LOT (+50) of unused symbols were preventing the build to pass.
I thought it was out of scope so I left it like so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.