Enemy/bosstelesa: decompile Boss Telesa behavior - #134
Open
KakarottoCake wants to merge 7 commits into
Open
Conversation
Report for GMSJ01 (5a8c71e - 60fcf3f)📈 Matched code: 35.52% (+0.21%, +7504 bytes) ✅ 65 new matches
...and 35 more new matches 📈 42 improvements in unmatched items
...and 12 more improvements in unmatched items |
KakarottoCake
changed the title
Contributor
Author
|
Follow-up on the latest commit ( Header
Source changes
Effect
TU fuzzy match: 90.38% → 93.18%. Remaining residuals are MWCC stack-frame padding, register-allocation shifts, and inlining depth (e.g. |
- route sounds through SMSGetMSound()->startSoundActor + SoundEffects enum - add boss telesa particle enum entries, use them in emit/load - use MsMtxSetXYZRPH f32 overload in TBubble::calcRootMatrix - drop fabricated isActorTypeOf, use direct actor-type comparisons - rename MActor::getAnmBck -> getCurBckAnmPtr (real map name) - unk198/unk1A8 -> bool[3] arrays (remove pointer fakematch) - rolling/allStopped -> bool, MsWrap-free 360 wraps restored - fabsf instead of __fabsf, CAM_SHAKE_MODE enum, SMSGetMarDirector
Contributor
Author
|
Addressed most of the review in Done
Pushed back on
Still TODO (not attempted / couldn't resolve cleanly)
One thing to flag: routing the sounds through the inline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Matching
.data,.rodata,.sdata,.sdata2, and.sbssTBossTelesa::loadAfteris 96.8%,generateSlotItemis 77.6%,TNerveBossTelesaSlotStart::executeis 79.5%, and compiler-generated__sinit_bosstelesa_cppis now an exact 100% matchTU structure
UNUSEDsymbolsVerification
ninja baselineninja changes_allninja all_source progress build/GMSJ01/report.jsonbuild/GMSJ01/mario.dol: OKpython tools/check-changed-symbol-order.py src/Enemy/bosstelesa.cpppython tools/validate-symbol-order.py -u mario/Enemy/bosstelesagit diff --checkThis is the full BossTelesa decompilation effort.