SelectMenu matching and naming. - #136
Open
CaptainProton42 wants to merge 1 commit into
Open
Conversation
Report for GMSJ01 (5a8c71e - c2a7034)📈 Matched code: 35.35% (+0.04%, +1476 bytes) ✅ 11 new matches
📈 8 improvements in unmatched items
|
CaptainProton42
force-pushed
the
SelectMenu
branch
from
August 9, 2026 21:53
6c09426 to
c2a7034
Compare
Mrkol
reviewed
Aug 9, 2026
| #ifndef GC2D_SELECT_MENU_HPP | ||
| #define GC2D_SELECT_MENU_HPP | ||
| #ifndef GC2D_SELECT_MENU_2_HPP | ||
| #define GC2D_SELECT_MENU_2_HPP |
Collaborator
There was a problem hiding this comment.
Why 2 when there's no 2 in the file name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still tons of issues with this but I think I've stared at this for long enough and am reaching the end of my abilities.
I've done the naming mostly by running the game with Dolphin Memory Engine attached.
I've also moved TSelectShineManager to its own file to mirror the structure of the TUs.