Skip to content

[no-release-notes] Fix SQLAlchemy pg_index expectation - #3249

Merged
fulghum merged 1 commit into
mainfrom
fulghum/doltgres-pg-index-test
Sep 1, 2026
Merged

[no-release-notes] Fix SQLAlchemy pg_index expectation#3249
fulghum merged 1 commit into
mainfrom
fulghum/doltgres-pg-index-test

Conversation

@fulghum

@fulghum fulghum commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Updates the SQLAlchemy catalog expectation missed by #3150. A single-column index reports indnkeyatts = 1, matching the existing Doltgres catalog behavior and the exact query result from PostgreSQL 16.13.

@fulghum fulghum changed the title Fix SQLAlchemy pg_index expectation [no-release-notes] Fix SQLAlchemy pg_index expectation Sep 1, 2026
@fulghum
fulghum enabled auto-merge September 1, 2026 00:42

@zachmu zachmu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 19289 19289
Failures 22801 22801
Partial Successes1 5459 5459
Main PR
Successful 45.8280% 45.8280%
Failures 54.1720% 54.1720%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@itoqa

itoqa Bot commented Sep 1, 2026

Copy link
Copy Markdown

Ito QA test results
Commit: 127d2bb: 2 test cases ran, 2 passed ✅.

Summary

Coverage focuses on database index behavior through direct catalog checks and application-level inspection, including index names, column order, uniqueness, and keeping primary-key information separate from secondary indexes. The exercised paths are successful creation and readback of both single-column and multi-column indexes, with no adversarial or user-interface behavior covered.

Safe to merge — the exercised index-management and inspection behavior passed without any PR-attributable regressions or unresolved failures. The run presents no merge-blocking application issues.

Tests run by Ito

View full run

Result Severity Type Description
Index The catalog query returned exactly one row for t2_b_idx with one key column, non-unique status, non-primary status, and column b in position 2.
Rev SQLAlchemy created a table with one single-column index and one two-column index, then read both back with the correct names, column order, and uniqueness. The primary key stayed separate from the list of secondary indexes.

Tip

Reply with @itoqa to send us feedback on this test run.

@coffeegoddd

Copy link
Copy Markdown
Contributor

@fulghum DOLT

read_tests from_latency to_latency percent_change
covering_index_scan_postgres 2.43 2.43 0.0
groupby_scan_postgres 77.19 77.19 0.0
index_join_postgres 2.22 2.18 -1.8
index_join_scan_postgres 1.58 1.58 0.0
index_scan_postgres 467.3 475.79 1.82
oltp_point_select 0.37 0.36 -2.7
oltp_read_only 6.32 6.32 0.0
select_random_points 0.7 0.72 2.86
select_random_ranges 1.01 1.01 0.0
table_scan_postgres 467.3 484.44 3.67
types_table_scan_postgres 1170.65 1213.57 3.67
write_tests from_latency to_latency percent_change
oltp_delete_insert_postgres 6.67 6.67 0.0
oltp_insert 3.36 3.3 -1.79
oltp_read_write 13.46 13.46 0.0
oltp_update_index 3.55 3.55 0.0
oltp_update_non_index 3.25 3.25 0.0
oltp_write_only 7.04 7.04 0.0
types_delete_insert_postgres 7.17 7.17 0.0

@fulghum
fulghum merged commit 0a1a307 into main Sep 1, 2026
28 checks passed
@fulghum
fulghum deleted the fulghum/doltgres-pg-index-test branch September 1, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants