Repository navigation
chore: 0.5.0 - #148
chore: 0.5.0#148
Conversation
…10-28 The holidays of pl, us-federal and us-banking were read against their sources again. The Polish Non-working Days Act (Dz.U. 1951 nr 4 poz. 28) has no amending act after the one in force from 2025-02-01, no public law enacted after 2026-10-06 touches 5 U.S.C. 6103, and the Federal Reserve's K.8 schedule for 2026-2030 still carries its update of 2026-07-08 with the same eleven holidays and the same Saturday and Sunday rule. The days do not change, so only law_as_of moves, and the changelog names the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The version lives in four places and all four move together: the Rust workspace in Cargo.toml (which drives the command-line tool), the window's build properties in gui/Directory.Build.props, Cargo.lock (seven workspace packages, refreshed by cargo update --workspace --offline), and gui/ChronoMock.App.Tests/packages.lock.json, where the project reference to ChronoMock.Protocol stands pinned and a plain restore does not move it, so the restore ran with --force-evaluate. That restore rewrote the other three lock files with CRLF and no content change, and those are left out rather than committed. The changelog's Unreleased section becomes the 0.5.0 entry, dated, with an empty Unreleased heading left above it - the release workflow looks for that heading first - and its link to the tag beside the ones before it. A minor version, because exit codes changed: another running session now ends a start with 7, and a report that could not be written with 8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Calendar review dates calendars/pl.json, calendars/us-banking.json, calendars/us-federal.json, CHANGELOG.md |
The three calendars set law_as_of to 2026-10-28. The changelog states that the holiday dates remain unchanged. |
Release metadata Cargo.toml, gui/Directory.Build.props, CHANGELOG.md |
The workspace and shared GUI versions change to 0.5.0. The changelog adds the 0.5.0 release heading and URL. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Merge Risk: 
95a0b
-
The release metadata and calendar review-date updates are consistent, with no actionable merge-blocking risk identified.
Pre-merge checks: 
-
Check name Status Explanation Resolution Title check The title 'chore: 0.5.0' names only a version bump. The PR also updates the changelog, calendar law_as_of dates for three calendars, and version metadata. It does not say what changes for users or the… Replace the title with a plain-language description of the change. Example: 'Release 0.5.0 and advance holiday calendar law_as_of to 2026-10-28'. Keep it under about 140 characters. Avoid vague wording such as 'chore' or 'update' with no su… Tests For Changed Behavior The PR changes non-UI runtime behavior without updating tests. Each changed calendar law_as_ofvalue is loaded by the CLI, returned ascalendar_law_as_of, and used bysignificance_ofto add `cal…Add regression coverage for the shipped pl,us-federal, andus-bankingcalendars. Assert that each reports2026-10-28ascalendar_law_as_of, and test thecalendar_outdatedboundary for the new check date. Keep or update any reco…-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. No Secrets Or Debug Leftovers PASS: The PR changes only release metadata, changelog text, calendar dates, and lockfile versions. The added lines contain no agent files, .envfiles, credentials, tokens, API keys, private URLs, lo…No Hardcoded Ui Styling The PR does not change UI code. Its only GUI-path changes are the assembly version in gui/Directory.Build.propsand a package lockfile. No XAML, Slint, Fyne, Tkinter, or WPF control code changes are…No Obvious Performance Problems The PR changes only release metadata, changelog text, calendar dates, and dependency lockfile version references. It adds no UI processing, I/O path, loop, query, timer, or collection handling that co… Desktop Robustness The PR changes only release metadata, changelog text, calendar JSON dates, and lockfile version pins. The authoritative diff contains no application source, asset-loading logic, file persistence, pars… Safe File Parsing No unsafe file parsing was introduced. The PR changes only version metadata, lockfile versions, changelog text, and the law_as_offield in three calendars; the calendar JSON content is otherwise unc…System Changes Are Reversible The PR changes no code that modifies system state. The authoritative diff contains only release metadata, lockfiles, changelog text, and three calendar law_as_ofvalues. No network filter, proxy, fi…Clear User-Facing Text The PR adds a dated changelog entry and release metadata only. The new calendar note is specific and names the affected calendars and dates. It adds no controls, icon-only buttons, error messages, or … No Resource Leaks PASS. The pull request changes only release metadata, changelog text, calendar JSON dates, and lockfiles. It does not add or modify executable code, event subscriptions, timers, handles, I/O ownership… Scope, Duplication And Docs PASS. The diff contains only the documented 0.5.0 release metadata, lockfile updates, three calendar law_as_ofupdates, and the matching CHANGELOG entry and release link. The PR description covers t…Full details: No Secrets Or Debug Leftovers
-
Explanation
PASS: The PR changes only release metadata, changelog text, calendar dates, and lockfile versions. The added lines contain no agent files,
.envfiles, credentials, tokens, API keys, private URLs, local absolute paths, private IPs, personal e-mails, or debug output/calls. The only new URL is the public GitHub release URL.
Full details: No Hardcoded Ui Styling
-
Explanation
The PR does not change UI code. Its only GUI-path changes are the assembly version in
gui/Directory.Build.propsand a package lockfile. No XAML, Slint, Fyne, Tkinter, or WPF control code changes are present, so the hardcoded UI styling check is not applicable.
Full details: No Obvious Performance Problems
-
Explanation
The PR changes only release metadata, changelog text, calendar dates, and dependency lockfile version references. It adds no UI processing, I/O path, loop, query, timer, or collection handling that could create a clear performance problem.
Full details: Desktop Robustness
-
Explanation
The PR changes only release metadata, changelog text, calendar JSON dates, and lockfile version pins. The authoritative diff contains no application source, asset-loading logic, file persistence, parsing, long-running operation, destructive action, window lifecycle, privilege, or network-call changes. The desktop robustness conditions are not introduced.
Full details: Safe File Parsing
-
Explanation
No unsafe file parsing was introduced. The PR changes only version metadata, lockfile versions, changelog text, and the
law_as_offield in three calendars; the calendar JSON content is otherwise unchanged and parses as valid JSON. The existing loader usesserde_jsonDTO deserialization, limits files to 4 MiB and 2,000 holidays, and rejects path traversal through validated catalogue IDs (crates/cli/src/calendar.rs:202-203, 446-450, 459-495, 653-666). No changed code reads, imports, or exports files.
Full details: System Changes Are Reversible
-
Explanation
The PR changes no code that modifies system state. The authoritative diff contains only release metadata, lockfiles, changelog text, and three calendar
law_as_ofvalues. No network filter, proxy, firewall, system time, process hook, service, registry, driver, or similar state-changing implementation is changed.
Full details: Clear User-Facing Text
-
Explanation
The PR adds a dated changelog entry and release metadata only. The new calendar note is specific and names the affected calendars and dates. It adds no controls, icon-only buttons, error messages, or confirmations, so none of the stated text failures apply.
Full details: No Resource Leaks
-
Explanation
PASS. The pull request changes only release metadata, changelog text, calendar JSON dates, and lockfiles. It does not add or modify executable code, event subscriptions, timers, handles, I/O ownership, tasks, queues, caches, or image storage. No resource leak is introduced.
Full details: Scope, Duplication And Docs
-
Explanation
PASS. The diff contains only the documented 0.5.0 release metadata, lockfile updates, three calendar
law_as_ofupdates, and the matching CHANGELOG entry and release link. The PR description covers these changes and the lockfile scope. No new functionality, duplicate implementation, architectural bypass, undocumented behavior change, or backward-incompatible API/configuration change is present in the changed files.
-
Full details: Title check
-
Explanation
The title 'chore: 0.5.0' names only a version bump. The PR also updates the changelog, calendar law_as_of dates for three calendars, and version metadata. It does not say what changes for users or the code. Under the title requirements, it is too vague to be understood in release notes or git history. It uses only a generic conventional-commit prefix and a version number.
Resolution
Replace the title with a plain-language description of the change. Example: 'Release 0.5.0 and advance holiday calendar law_as_of to 2026-10-28'. Keep it under about 140 characters. Avoid vague wording such as 'chore' or 'update' with no subject.
Full details: Tests For Changed Behavior
-
Explanation
The PR changes non-UI runtime behavior without updating tests. Each changed calendar
law_as_ofvalue is loaded by the CLI, returned ascalendar_law_as_of, and used bysignificance_ofto addcalendar_outdated. Moving the date from 2026-10-06 to 2026-10-28 changes the warning boundary and the reported metadata. The PR changes no test source or assertion; existing tests use synthetic dates and do not verify the three shipped dates. No tests were deleted or weakened.Resolution
Add regression coverage for the shipped
pl,us-federal, andus-bankingcalendars. Assert that each reports2026-10-28ascalendar_law_as_of, and test thecalendar_outdatedboundary for the new check date. Keep or update any recorded fixtures that represent these values.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
What
Release 0.5.0: the version moves in its four places, the changelog's Unreleased section becomes the dated 0.5.0 entry, and the three holiday calendars carry the day their law was last checked.
The change
71829bc-law_as_ofmoves from 2026-10-06 to 2026-10-28 inpl,us-federalandus-banking, with a changelog line that names the check. No holiday changes:95a0b6a-chore: 0.5.0, the same set of files as the 0.4.0 bump:Cargo.toml[workspace.package]andgui/Directory.Build.props,Cargo.lockthroughcargo update --workspace --offline(exactly the seven workspace packages),gui/ChronoMock.App.Tests/packages.lock.jsonthroughdotnet restore --force-evaluate, where the project reference toChronoMock.Protocolis pinned. The three other lock files that restore rewrote only with CRLF are left out.[Unreleased]heading above## [0.5.0] - 2026-10-28and gains the tag link.A minor version, because exit codes changed since 0.4.0: another running session ends a start with 7, and a report that could not be written ends the run with 8.
Evidence
TAG=v0.5.0: no entry left under[Unreleased], a dated 0.5.0 section found.chrono versionprintschrono 0.5.0, and the window's assembly carries 0.5.0.calc_clipass with the new calendar files.🤖 Generated with Claude Code
Summary by CodeRabbit