Repository navigation
build: Go 1.27.2, and eml - pictures in the text, messages inside messages, recipients, base64 text and two more character sets - #176
Conversation
…sages, recipients, base64 text and two more character sets Go 1.27.2 fixes ten vulnerabilities govulncheck reported on 2026-10-12 in net/http, net/textproto, crypto/tls and html/template, all reachable from the desktop window through its toolkit. The command line tool links none of them. Generated bytes are unchanged under 1.27.2. CI moves to govulncheck v1.9.0 and staticcheck v0.8.2. eml gains inline, inline_format and inline_size (pictures the text shows, through cid: beside an HTML and after a plain text), attachment_format=eml with message_depth up to 2000 (messages inside each other, the way mail is forwarded), recipients up to 100 000 addresses in To, charset iso-8859-2 and windows-1250, text_encoding=base64 and filename_style=none. The manifest records inline_bytes and inline_encoded_bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Desktop Robustness |  |
The new message_depth feature creates an uncancellable long planning operation. planner.forward recursively calls desc.Generator.Plan for each depth level (up to 2,000), and generator.Plan rep… |
Add a context-aware planning path and use it for EML recursion. Thread the run context through PlanContext, generator.Plan, planChildren, forward, and all sizing loops; check ctx.Err() between depth levels and repeated size calcul… |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main changes: the Go 1.27.2 update and the new EML features. It is specific enough for release notes and is within the approximately 140-character limit. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Tests For Changed Behavior The changed EML runtime behavior has new or updated coverage: base64 sizing and Message-ID handling, charsets, inline pictures and Content-IDs, recipients, raw nested messages and message depth, MIME … No Secrets Or Debug Leftovers The PR diff adds no CLAUDE.md, CLAUDE.local.md, AGENTS.md, .claude, or .env files. No added lines contain credentials, private URLs, local absolute paths, internal hosts/IPs, or debug output calls. Th… No Hardcoded Ui Styling The PR does not add or change GUI code. Its only internal/guichanges are four JSON locale files containing labels and messages. No XAML, Slint, Fyne, Tkinter, WPF code-behind, or UI styling literal…No Obvious Performance Problems No clear performance problem was introduced. Recipient, picture, and MIME-part processing uses linear loops. Base64 sizing uses a logarithmic search. The changed GUI files contain locale data only, an… Safe File Parsing No unsafe file-parsing behavior is introduced. The changed JSON files are static locale and manifest data; all 27 changed JSON files parse with Python json.loads. The diff adds no unsafe YAML/XML/CSV/… System Changes Are Reversible The PR does not add or change code for network filters, proxies, firewalls, system time, process hooking/injection, Windows services, registry, or drivers. The changed production code generates and pa… Clear User-Facing Text PASS — The PR adds user-facing EML labels, details, documentation, and validation text. Each new setting has a label and detail entry. Numeric settings expose ranges or size syntax through the shared … No Resource Leaks No resource leak is introduced. The changed production code uses local plans, slices, builders, and streaming writers only. Inline pictures retain generation metadata, not image bytes, and their count… Scope, Duplication And Docs The PR scope matches the title and description. The Go 1.27.2, govulncheck, and staticcheck updates are described, and the EML features, archive nesting flag, oracle changes, tests, translations, and …
Full details: Desktop Robustness
-
Explanation
The new
message_depthfeature creates an uncancellable long planning operation.planner.forwardrecursively callsdesc.Generator.Planfor each depth level (up to 2,000), andgenerator.Planrepeatedly sizes and serializes the nested message.engine.PlanContextchecks cancellation only after the outer generator plan returns, so the GUI Cancel and window-close paths cannot stop this work and no progress is reported during it. The GUI does prevent a second run, but that does not resolve the planning hang.Resolution
Add a context-aware planning path and use it for EML recursion. Thread the run context through
PlanContext,generator.Plan,planChildren,forward, and all sizing loops; checkctx.Err()between depth levels and repeated size calculations. Report planning progress, or impose a bounded planning cost before starting. Keep the existing GUI busy-state and double-run guard, and add a cancellation test for a deepmessage_depthrequest.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
coderabbitai
Bot
added
dependencies
…ize; the changelog in ASCII The window spelled the three labels out of their recipe keys, and inline is a word from MIME a person meeting the window does not know. The key is still shown on hover, and a guard asks every label written by hand to still belong to a declared setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…reads it screens.go had grown past the file ceiling. The hand-written labels reach a translator through the registry catalogue, so the guard that asks every sentence of the text package to go through the catalogue names them, and it now reads the new file - it reads a list of files, and a file left off the list is a file it never sees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
Two things on one branch.
Go 1.27.2. The scheduled CI run of 2026-10-12 was red in
govulncheck: ten vulnerabilities in the standard library (net/http,net/textproto,crypto/tls,html/template), reachable from the desktop window through its toolkit. The command line tool links none of them.go.mod,GO_VERSIONin the three workflows, README and CONTRIBUTING move to 1.27.2,govulncheckto v1.9.0 andstaticcheckto v0.8.2. Generated bytes do not move - the golden values and the standard library outputs are unchanged. A### Securityentry in the changelog.eml, the second set of settings.
inline,inline_format,inline_size- pictures the text shows. Beside an HTML each has a Content-ID and the HTML shows it throughcid:insidemultipart/related. Beside a plain text they follow it. Readers count them differently: mailparser lists every picture among the attachments, Python'semailpackage lists them when the HTML is alone, MimeKit never does.attachment_format=emlattaches a message as it is (message/rfc822, the way mail is forwarded), andmessage_depthputs up to 2000 messages inside each other. Python 3.14 runs out of recursion at around 490, MimeKit stops taking them apart past 513 without a word.recipients- up to 100 000 addresses inTo, each on a line of its own, past the 1 MiB of header mailparser refuses.charset-iso-8859-2orwindows-1250, which write ą, ś and ź as different bytes.text_encoding=base64- the whole text in base64.filename_style=none- no name at all.inline_bytesandinline_encoded_bytes.Around it
archive.DoorgainsNests: a container may hold a file of its own format. Archives still refuse it, a message does not.strict.pycheck_emlwalks nested parts,multipart/related,message/rfc822, base64 text and the two character sets.Checked by
emailpackage, mailparser, MimeKit and Go's standard library.emlparts_test.go,emltext_test.go), eight new golden values, the parity guard.🤖 Generated with Claude Code
Summary by CodeRabbit