[3.0] Add --only option to SilkTouch#2591
Merged
Merged
Conversation
I've always felt the Program-class-less entrypoint approach to be less readable. It's fine if it's only a few lines, but logic, methods, and constants start to blur together.
Contributor
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 69a2a26 |
curin
approved these changes
Jun 12, 2026
72 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This was originally implemented in #2406 by Curin. I ported this back to the main branch now that I'm planning on adding more jobs.
I also decided to change the SilkTouch entrypoint to use a Program class instead of the top-level statement (entrypoint with no Program class/Main method) approach currently used. I like the structure that the Program provides since it prevents methods, constants, and logic from blurring together. In my opinion, top-level statements are only nice when the entrypoint is simple.
Related issues, Discord discussions, or proposals
Original implementation: https://github.com/dotnet/Silk.NET/pull/2406/changes?show-viewed-files=false#diff-029de316f704ec70da7eeb03b1ff777ca03df4c441bc519ba460d596b23ab14dL20
Further Comments
N/A